Fix file:// URLs on Windows #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is closely related to the issue mentioned in ariga/atlas#1528 |
rotemtam
reviewed
Jun 6, 2024
| @@ -144,7 +145,7 @@ func (d *MigrationDataSource) Read(ctx context.Context, req datasource.ReadReque | |||
| return | |||
| } | |||
| r, err := d.client.MigrateStatus(ctx, &atlas.MigrateStatusParams{ | |||
| ConfigURL: fmt.Sprintf("file://%s", cfgPath), | |||
| ConfigURL: fmt.Sprintf("file://%s", strings.ReplaceAll(cfgPath, `\`, "/")), | |||
There was a problem hiding this comment.
Do you know https://pkg.go.dev/path/filepath#ToSlash?
There was a problem hiding this comment.
I didn't, perfect! I shall update the PR...
NathanBaulch
force-pushed
the
windows-support
branch
from
8410e26 to
07c6f2e
Compare
|
Hey @NathanBaulch, thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simple PR fixes an "invalid port"
url.Parseissue caused by back-slashes infile://URLs on Windows.I can confirm that my Terraform based migrations completed successfully when running this patched version.