Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mr/falkor Puppet 4 version, transparent support for arrays and vagrant-based tests #12

Open
wants to merge 51 commits into
base: master
Choose a base branch
from

Conversation

Falkor
Copy link

@Falkor Falkor commented Oct 5, 2017

Dear Tom,

Here are the changes I made to publish the ulimit module under my own namespace on Puppet forge (see svarrette/ulimit) while waiting for your own new release as per Issue #9.
I didn't want to touch it initially, but I couldn't prevent myself to extend the offered features and ensure a maximal scoring on Puppet Forge.
In short (sorry for the messy list of commits inherent to my internal versionning policy):

  • Puppet String documentation and enhanced README.md
  • minor corrections in metadata.json
  • Integration of Vagrant-based tests (including. highly customizable Vagrantfile and provisioning scripts)
    • Enhanced tests in tests/
  • Within ulimit::rule:
    • Support for String or Arrays (transparently) for the $ulimit_type and/or $ulimit_item parameters. Based on initial merge request of Jake Humphries aka Jake151 (yet I was not a fan of making it enfore the same array length)
    • Support for new parameters source and content

Jake Humphries and others added 30 commits January 20, 2016 16:52
Signed-off-by: Sebastien Varrette <Sebastien.Varrette@uni.lu>
Signed-off-by: Sebastien Varrette <Sebastien.Varrette@uni.lu>
Signed-off-by: Sebastien Varrette <Sebastien.Varrette@uni.lu>
Signed-off-by: Sebastien Varrette <Sebastien.Varrette@uni.lu>
Signed-off-by: Sebastien Varrette <Sebastien.Varrette@uni.lu>
Signed-off-by: Sebastien Varrette <Sebastien.Varrette@uni.lu>
Signed-off-by: Sebastien Varrette <Sebastien.Varrette@uni.lu>
Puppet 4 compliant released version of arioch/ulimit
Signed-off-by: Sebastien Varrette <Sebastien.Varrette@uni.lu>
Signed-off-by: Sebastien Varrette <Sebastien.Varrette@uni.lu>
metadata update
Signed-off-by: Sebastien Varrette <Sebastien.Varrette@uni.lu>
Signed-off-by: Sebastien Varrette <Sebastien.Varrette@uni.lu>
Signed-off-by: Sebastien Varrette <Sebastien.Varrette@uni.lu>
Signed-off-by: Sebastien Varrette <Sebastien.Varrette@uni.lu>
Signed-off-by: Sebastien Varrette <Sebastien.Varrette@uni.lu>
Signed-off-by: Sebastien Varrette <Sebastien.Varrette@uni.lu>
Signed-off-by: Sebastien Varrette <Sebastien.Varrette@uni.lu>
Signed-off-by: Sebastien Varrette <Sebastien.Varrette@uni.lu>
support for source and content
Signed-off-by: Sebastien Varrette <Sebastien.Varrette@uni.lu>
Signed-off-by: Sebastien Varrette <Sebastien.Varrette@uni.lu>
Signed-off-by: Sebastien Varrette <Sebastien.Varrette@uni.lu>
Better README
Sebastien Varrette added 21 commits October 5, 2017 17:00
Signed-off-by: Sebastien Varrette <Sebastien.Varrette@uni.lu>
Signed-off-by: Sebastien Varrette <Sebastien.Varrette@uni.lu>
Final corrections and vagrant tests
Signed-off-by: Sebastien Varrette <Sebastien.Varrette@uni.lu>
Signed-off-by: Sebastien Varrette <Sebastien.Varrette@uni.lu>
forge score improvement
Signed-off-by: Sebastien Varrette <Sebastien.Varrette@uni.lu>
Signed-off-by: Sebastien Varrette <Sebastien.Varrette@uni.lu>
Signed-off-by: Sebastien Varrette <Sebastien.Varrette@uni.lu>
Forge score of 5.0
Signed-off-by: Sebastien Varrette <Sebastien.Varrette@uni.lu>
Signed-off-by: Sebastien Varrette <Sebastien.Varrette@uni.lu>
cosmetics in README
Signed-off-by: Sebastien Varrette <Sebastien.Varrette@uni.lu>
Signed-off-by: Sebastien Varrette <Sebastien.Varrette@uni.lu>
support for any type on value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant