Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Banner template has rstrip function configured and remove some lines #394

Closed
titom73 opened this issue Nov 27, 2020 · 0 comments · Fixed by #395
Closed

Banner template has rstrip function configured and remove some lines #394

titom73 opened this issue Nov 27, 2020 · 0 comments · Fixed by #395
Assignees
@titom73
Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role state: in-progress Currently work in progress type: bug Something isn't working
Milestone
v1.1.1

Comments

@titom73
Copy link
Contributor

titom73 commented Nov 27, 2020 •
edited
Loading

Issue Type

  • Bug Report

Summary

When setting a login banned using multilines, delimiter is not set correctly in the output

Initially reported by @mpergament

Role or Module Name

arista.avd collection and Python libraries version

Steps to reproduce

banners:
  login: |-
    My first banner line
    Connected to Device $(hostname) EOF

Expected results

!
banner login
My first banner line
    Connected to Device $(hostname) EOF
!

Actual results

banner login
My first banner line
    Connected to Device $(hostname) EOF!
@titom73 titom73 added type: bug Something isn't working role: eos_cli_config_gen issue related to eos_cli_config_gen role state: in-progress Currently work in progress labels Nov 27, 2020
@titom73 titom73 added this to the v1.1.1 milestone Nov 27, 2020
@titom73 titom73 self-assigned this Nov 27, 2020
@titom73 titom73 mentioned this issue Nov 27, 2020
Merged
12 tasks
carlbuchmann added a commit that referenced this issue Nov 28, 2020
@carlbuchmann
Merge pull request #395 from titom73/issues/394
9148390 
Fix incorrect rstrip configuration #394
@titom73 titom73 mentioned this issue Sep 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@titom73 titom73

Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role state: in-progress Currently work in progress type: bug Something isn't working
Projects
None yet
Milestone
v1.1.1
Development

Successfully merging a pull request may close this issue.

Fix incorrect rstrip configuration #394
1 participant
@titom73