Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for BGP default timers and send-community commands #4218

Closed
1 task done
dgonzalez85 opened this issue Jul 16, 2024 · 2 comments · Fixed by #4607
Closed
1 task done

Support for BGP default timers and send-community commands #4218

dgonzalez85 opened this issue Jul 16, 2024 · 2 comments · Fixed by #4607
Assignees
Labels
type: enhancement New feature or request

Comments

@dgonzalez85
Copy link

Enhancement summary

We are looking to remove this commands from the fabric file:

bgp_defaults:
      - timers bgp 5 15
      - neighbor default send-community

And support them as native ansible vars. However this is not supported today via "eos_cli_config_gen" for all neighbours, only for peer-grups:

https://avd.arista.com/4.9/roles/eos_cli_config_gen/docs/input-variables.htmlhttps://avd.arista.com/4.9/roles/eos_cli_config_gen/docs/input-variables.html

peer_groups:

      # Peer-group name.
    - name: <str; required; unique>

      # Key only used for documentation or validation purposes.
      type: <str>
     [...]
       # 'all' or a combination of 'standard', 'extended', 'large' and 'link-bandwidth (w/options)'.
      send_community: <str>

      # BGP Keepalive and Hold Timer values in seconds as string "<0-3600> <0-3600>".
      timers: <str>

We would like support this also under global BGP settings, so it applies to any new peer-groups that are defined.

Which component of AVD is impacted

eos_cli_config_gen

Use case example

Remove bgp_defaults cli commands and use eos_cli_config_gen.

Describe the solution you would like

Support the commands above under bgp general settings also.

Describe alternatives you have considered

No response

Additional context

No response

Contributing Guide

  • I agree to follow this project's Code of Conduct
@dgonzalez85 dgonzalez85 added the type: enhancement New feature or request label Jul 16, 2024
@dgonzalez85
Copy link
Author

@carlbuchmann opened as requested. thanks

@ClausHolbechArista
Copy link
Contributor

So the request is to add support for generating:

router bgp 65123
   timers bgp 5 15
   neighbor default send-community

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
3 participants