-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_cli_config_gen): Add support for BGP default timers and send-community commands #4607
Merged
ClausHolbechArista
merged 14 commits into
aristanetworks:devel
from
Shivani-gslab:bgp_timers_send_community
Nov 15, 2024
Merged
Feat(eos_cli_config_gen): Add support for BGP default timers and send-community commands #4607
ClausHolbechArista
merged 14 commits into
aristanetworks:devel
from
Shivani-gslab:bgp_timers_send_community
Nov 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4607
# Activate the virtual environment
source test-avd-pr-4607/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Shivani-gslab/avd.git@bgp_timers_send_community#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Shivani-gslab/avd.git#/ansible_collections/arista/avd/,bgp_timers_send_community --force
# Optional: Install AVD examples
cd test-avd-pr-4607
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
labels
Oct 17, 2024
MaheshGSLAB
reviewed
Oct 17, 2024
ansible_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/router-bgp-base.cfg
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/router_bgp.schema.yml
Outdated
Show resolved
Hide resolved
...ections/arista/avd/molecule/eos_cli_config_gen/documentation/devices/router-bgp-evpn-mpls.md
Outdated
Show resolved
Hide resolved
Vibhu-gslab
force-pushed
the
bgp_timers_send_community
branch
from
October 18, 2024 10:08
5e307ca
to
5bea855
Compare
Vibhu-gslab
reviewed
Oct 18, 2024
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/router_bgp.schema.yml
Outdated
Show resolved
Hide resolved
Vibhu-gslab
force-pushed
the
bgp_timers_send_community
branch
from
October 21, 2024 07:42
c485a9e
to
a94d7d5
Compare
ClausHolbechArista
requested changes
Nov 8, 2024
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/router-bgp.j2
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/router_bgp.schema.yml
Outdated
Show resolved
Hide resolved
ClausHolbechArista
requested changes
Nov 11, 2024
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/router_bgp.schema.yml
Show resolved
Hide resolved
Shivani-gslab
force-pushed
the
bgp_timers_send_community
branch
from
November 11, 2024 10:19
4239a52
to
3e2a026
Compare
ClausHolbechArista
requested changes
Nov 11, 2024
...a/avd/molecule/eos_cli_config_gen/inventory/host_vars/router-bgp-evpn-vpn-import-pruning.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/router-bgp.j2
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/router-bgp.j2
Outdated
Show resolved
Hide resolved
Shivani-gslab
force-pushed
the
bgp_timers_send_community
branch
2 times, most recently
from
November 11, 2024 11:11
0917539
to
b013b07
Compare
Shivani-gslab
force-pushed
the
bgp_timers_send_community
branch
from
November 13, 2024 06:57
167b11e
to
95deb9a
Compare
…-community commands
Co-authored-by: laxmikantchintakindi <159624484+laxmikantchintakindi@users.noreply.github.com>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Shivani-gslab
force-pushed
the
bgp_timers_send_community
branch
from
November 13, 2024 06:57
95deb9a
to
ccf8103
Compare
Shivani-gslab
requested review from
alexeygorbunov,
ClausHolbechArista,
Vibhu-gslab,
laxmikantchintakindi and
MaheshGSLAB
November 13, 2024 06:59
ClausHolbechArista
requested changes
Nov 13, 2024
...collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/router-bgp-evpn-mpls.cfg
Show resolved
Hide resolved
alexeygorbunov
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ClausHolbechArista
approved these changes
Nov 15, 2024
Quality Gate passedIssues Measures |
ashenoy-arista
pushed a commit
to ashenoy-arista/avd
that referenced
this pull request
Nov 21, 2024
…-community commands (aristanetworks#4607)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
rn: Feat(eos_cli_config_gen)
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Add support for BGP default timers and send-community commands
Related Issue(s)
Fixes #4218
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
How to test
Match with EOS CLI.
Checklist
User Checklist
Repository Checklist