-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Interface Profiles in port-channel interfaces #4621
Comments
I'm interested in contributing. What else shall I update than jinja2 template? |
You would need to update the schema fragment for Let us know if you need help. |
So now I have added interface profile to j2 template as well as test to Where I can find schema fragment? |
Hi @JaakkoRautanen - You can find the schema you are looking for in https://github.com/aristanetworks/avd/tree/devel/python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments |
I think I found schema fragment part. What about documentation? Where should I add information about interface profile part? |
documentation is auto-generated when you run pre-commit locally - so in theory you have nothing to do in this case https://avd.arista.com/5.0/docs/contribution/development-tooling.html#pre-commit |
Hey, I think I made my best and came up with draft PR. Could somebody check it? |
Enhancement summary
Port-channel interfaces in EOS support Interface Profiles just like normal Ethernet interfaces. However, AVD doesn't have that feature in port-channel-interfaces.j2. Let's add it.
Which component of AVD is impacted
eos_cli_config_gen
Use case example
Attach Interface Profile to port-channel interface.
Describe the solution you would like
You should be able to refer to Interface Profiles under port-channel interface same way as with Ethernet interfaces:
profile: <str>
Solution can be copied from ethernet-interfaces.py.
Describe alternatives you have considered
No response
Additional context
No response
Contributing Guide
The text was updated successfully, but these errors were encountered: