Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Interface Profiles in port-channel interfaces #4621

Closed
1 task done
JaakkoRautanen opened this issue Oct 21, 2024 · 7 comments · Fixed by #4661
Closed
1 task done

Support for Interface Profiles in port-channel interfaces #4621

JaakkoRautanen opened this issue Oct 21, 2024 · 7 comments · Fixed by #4661
Assignees
Labels
type: enhancement New feature or request

Comments

@JaakkoRautanen
Copy link
Contributor

JaakkoRautanen commented Oct 21, 2024

Enhancement summary

Port-channel interfaces in EOS support Interface Profiles just like normal Ethernet interfaces. However, AVD doesn't have that feature in port-channel-interfaces.j2. Let's add it.

Which component of AVD is impacted

eos_cli_config_gen

Use case example

Attach Interface Profile to port-channel interface.

Describe the solution you would like

You should be able to refer to Interface Profiles under port-channel interface same way as with Ethernet interfaces: profile: <str>

Solution can be copied from ethernet-interfaces.py.

Describe alternatives you have considered

No response

Additional context

No response

Contributing Guide

  • I agree to follow this project's Code of Conduct
@JaakkoRautanen JaakkoRautanen added the type: enhancement New feature or request label Oct 21, 2024
@JaakkoRautanen
Copy link
Contributor Author

I'm interested in contributing. What else shall I update than jinja2 template?

@ClausHolbechArista
Copy link
Contributor

I'm interested in contributing. What else shall I update than jinja2 template?

You would need to update the schema fragment for port_channel_interfaces as well and then add a test in ansible_collections/arista/avd/molecule/eos_cli_config_gen/inventory/host_vars/port-channel-intefaces.yml or similar.

Let us know if you need help.

@JaakkoRautanen
Copy link
Contributor Author

JaakkoRautanen commented Oct 28, 2024

So now I have added interface profile to j2 template as well as test to ...host_vars/port-channel-intefaces.yml and expected cli result to ...intended/configs/port-channel-intefaces.cfg.

Where I can find schema fragment?

@gmuloc
Copy link
Contributor

gmuloc commented Oct 28, 2024

@JaakkoRautanen
Copy link
Contributor Author

JaakkoRautanen commented Oct 28, 2024

I think I found schema fragment part.

What about documentation? Where should I add information about interface profile part?

@gmuloc
Copy link
Contributor

gmuloc commented Oct 28, 2024

documentation is auto-generated when you run pre-commit locally - so in theory you have nothing to do in this case

https://avd.arista.com/5.0/docs/contribution/development-tooling.html#pre-commit

@JaakkoRautanen
Copy link
Contributor Author

Hey, I think I made my best and came up with draft PR. Could somebody check it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
3 participants