-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_cli_config_gen): Support for Interface Profiles on Port-channel interfaces #4661
Conversation
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4661
# Activate the virtual environment
source test-avd-pr-4661/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/JaakkoRautanen/avd.git@issue_4621#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/JaakkoRautanen/avd.git#/ansible_collections/arista/avd/,issue_4621 --force
# Optional: Install AVD examples
cd test-avd-pr-4661
ansible-playbook arista.avd.install_examples |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At first glance the PR looks good - I checked and we have no documentation for profile(s) applied for ethernet_interfaces
though I would expect it could be quite valuable as a user what are your thoughts?
feel free to mark the PR as ready for review so other can review as well
Documentation would be useful for sure. What is correct place to add it? |
so the idea would be to add it in the pendant documentation templates for port-channels in this folder: https://github.com/aristanetworks/avd/tree/devel/python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation I have not gauged exactly what level of effort it would require and it could be quite convoluted so feel free to lets us know if you need some assist here. |
I tried to look for example from |
yeah that's what I was saying in a previous comment:
Let me give it a try for both |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - lets merge as it is without further effort in documentaiton for now
Change Summary
Adds support for Interface Profiles on Port-channel interfaces
Related Issue(s)
Fixes #4621
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
profile
toport_channel_interfaces.schema.yml
port-channel-interfaces.j2
How to test
Checklist
User Checklist
Repository Checklist