Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Support for Interface Profiles on Port-channel interfaces #4661

Merged
merged 13 commits into from
Nov 5, 2024

Conversation

JaakkoRautanen
Copy link
Contributor

Change Summary

Adds support for Interface Profiles on Port-channel interfaces

Related Issue(s)

Fixes #4621

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

  • Added profile to port_channel_interfaces.schema.yml
  • Added profile section to port-channel-interfaces.j2
  • Added test

How to test

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Oct 28, 2024
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4661
# Activate the virtual environment
source test-avd-pr-4661/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/JaakkoRautanen/avd.git@issue_4621#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/JaakkoRautanen/avd.git#/ansible_collections/arista/avd/,issue_4621 --force
# Optional: Install AVD examples
cd test-avd-pr-4661
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: Documentation role Updated labels Oct 28, 2024
@JaakkoRautanen JaakkoRautanen changed the title Support for Interface Profiles on Port-channel interfaces feat: Support for Interface Profiles on Port-channel interfaces Oct 28, 2024
@JaakkoRautanen JaakkoRautanen changed the title feat: Support for Interface Profiles on Port-channel interfaces Feat(eos_cli_config_gen): Support for Interface Profiles on Port-channel interfaces Oct 28, 2024
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first glance the PR looks good - I checked and we have no documentation for profile(s) applied for ethernet_interfaces though I would expect it could be quite valuable as a user what are your thoughts?

feel free to mark the PR as ready for review so other can review as well

@JaakkoRautanen JaakkoRautanen marked this pull request as ready for review October 29, 2024 06:15
@JaakkoRautanen JaakkoRautanen requested review from a team as code owners October 29, 2024 06:15
@JaakkoRautanen
Copy link
Contributor Author

Documentation would be useful for sure. What is correct place to add it?

@gmuloc
Copy link
Contributor

gmuloc commented Oct 29, 2024

Documentation would be useful for sure. What is correct place to add it?

so the idea would be to add it in the pendant documentation templates for port-channels in this folder: https://github.com/aristanetworks/avd/tree/devel/python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation

I have not gauged exactly what level of effort it would require and it could be quite convoluted so feel free to lets us know if you need some assist here.

@JaakkoRautanen
Copy link
Contributor Author

I tried to look for example from ethernet-interfaces.j2 in that folder. But could not find any reference for Interface Profile. I don't no what to do.

@gmuloc
Copy link
Contributor

gmuloc commented Nov 5, 2024

I checked and we have no documentation for profile(s) applied for ethernet_interfaces

yeah that's what I was saying in a previous comment:

I checked and we have no documentation for profile(s) applied for ethernet_interfaces

Let me give it a try for both

Copy link

sonarcloud bot commented Nov 5, 2024

@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Nov 5, 2024
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - lets merge as it is without further effort in documentaiton for now

@gmuloc gmuloc merged commit f2d1fc0 into aristanetworks:devel Nov 5, 2024
45 checks passed
@JaakkoRautanen JaakkoRautanen deleted the issue_4621 branch November 5, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Interface Profiles in port-channel interfaces
4 participants