Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storm-control settings in l3ls_evpn #534

Closed
onurgashi opened this issue Dec 23, 2020 · 0 comments · Fixed by #557
Closed

Storm-control settings in l3ls_evpn #534

onurgashi opened this issue Dec 23, 2020 · 0 comments · Fixed by #557
Assignees
Labels
role: eos_l3ls_evpn issue related to eos_l3ls_evpn role type: bug Something isn't working

Comments

@onurgashi
Copy link
Contributor

Issue Type

  • Bug Report
  • Documentation Issue Report
  • EOS Configuration error

Summary

This got solved for eos_cli_config_gen where the unit is optional, but in l3ls it's mandatory and some platforms don't support it.

    storm_control:
      all:
        level: < Configure maximum storm-control level >
        unit: < percent* | pps (optional and is hardware dependant - default is percent)>

We would need to factor this in for eos_l3ls_evpn and make it optional

{%                 if port_profiles[adapter.profile].storm_control is defined and port_profiles[adapter.profile].storm_control is not none %}
    storm_control:
{%                     for section in port_profiles[adapter.profile].storm_control %}
      {{ section }}:
        level: {{ port_profiles[adapter.profile].storm_control[section].level }}
        unit: {{ port_profiles[adapter.profile].storm_control[section].unit }}
{%                     endfor %}
{%                 endif %}

Role or Module Name

eos_l3ls_evpn

OS / Environment

EOS Version

Cloudvision version (optional)

OS running Ansible

Steps to reproduce

Expected results

$

Actual results

@onurgashi onurgashi added type: bug Something isn't working role: eos_l3ls_evpn issue related to eos_l3ls_evpn role labels Dec 23, 2020
@onurgashi onurgashi self-assigned this Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
role: eos_l3ls_evpn issue related to eos_l3ls_evpn role type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant