Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storm control in l3ls_evpn the unit as optional #557

Merged
merged 1 commit into from
Dec 31, 2020
Merged

Storm control in l3ls_evpn the unit as optional #557

merged 1 commit into from
Dec 31, 2020

Conversation

onurgashi
Copy link
Contributor

Change Summary

Made changes in the template so that the unit is considered as optional instead of mandatory as some platforms don't support it.

After the changes, tests show positive

7280r2...15:05:02(config-if-Et1)#   storm-control broadcast level 10
7280r2...15:05:03(config-if-Et1)#   storm-control multicast level 20
7280r2...15:05:03(config-if-Et1)#   storm-control unknown-unicast level pps 15
% Unavailable command (not supported on this hardware platform)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Documentation content changes
  • Other (please describe):

Related Issue(s)

Fixes #534

Component(s) name

leaf-server-interfaces.j2
eos_l3ls_evpn

Proposed changes

{%                         if port_profiles[adapter.profile].storm_control[section].unit is defined and port_profiles[adapter.profile].storm_control[section].unit is not none %}
        unit: {{ port_profiles[adapter.profile].storm_control[section].unit }}
{%                         endif %}

How to test

interface Ethernet4
   description server02_Eth0
   switchport trunk allowed vlan 210-211
   switchport mode trunk
   storm-control broadcast level 10
   storm-control multicast level 20
   storm-control unknown-unicast level pps 15

YAML

  TENANT_B:
    mode: trunk
    vlans: "210-211"
    storm_control:
      broadcast:
        level: 10
      multicast:
        level: 20
      unknown_unicast:
        level: 15
        unit: pps

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed (pre-commit, make linting and make sanity-lint).
  • I have updated molecule CI testing accordingly

@onurgashi onurgashi added type: bug Something isn't working role: eos_l3ls_evpn issue related to eos_l3ls_evpn role labels Dec 29, 2020
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@titom73 titom73 added this to the v1.2.0 milestone Dec 31, 2020
@titom73 titom73 merged commit e3df86a into aristanetworks:devel Dec 31, 2020
@titom73
Copy link
Contributor

titom73 commented Jan 26, 2021

@titom73 titom73 mentioned this pull request Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick role: eos_l3ls_evpn issue related to eos_l3ls_evpn role state: Documentation role Updated type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storm-control settings in l3ls_evpn
3 participants