Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(eos_cli_config_gen): Relax schema for maintenance unit profile #2492

Merged
merged 5 commits into from
Feb 8, 2023
Merged

Fix(eos_cli_config_gen): Relax schema for maintenance unit profile #2492

merged 5 commits into from
Feb 8, 2023

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Feb 6, 2023

Change Summary

Make the key maintenance.units[UNIT_NAME].profile not required as this for instance is a valid config:

Leaf1#show run se maintenance
maintenance
   unit System
   !

Related Issue(s)

Fixes #2488

Component(s) name

arista.avd.eos_cli_config_gen

How to test

Added a test to molecule to make sure this config is captured.

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gmuloc gmuloc requested a review from a team as a code owner February 6, 2023 14:00
@gmuloc gmuloc added the cherry-pick-for-3.8.x PR to be cherry-picked to releases/v3.8.x brach later label Feb 6, 2023
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Feb 6, 2023
carlbuchmann
carlbuchmann approved these changes Feb 6, 2023
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann requested a review from a team February 6, 2023 18:06
@ClausHolbechArista ClausHolbechArista merged commit 02286e8 into aristanetworks:devel Feb 8, 2023
@carlbuchmann carlbuchmann added this to the v3.8.2 milestone Feb 13, 2023
carlbuchmann pushed a commit to carlbuchmann/avd that referenced this pull request Feb 13, 2023
@gmuloc @carlbuchmann
Fix(eos_cli_config_gen): Relax schema for maintenance unit profile (a…
7722625 
…ristanetworks#2492)
@carlbuchmann carlbuchmann removed the cherry-pick-for-3.8.x PR to be cherry-picked to releases/v3.8.x brach later label Feb 13, 2023
@carlbuchmann carlbuchmann mentioned this pull request Feb 13, 2023
Merged
carlbuchmann added a commit that referenced this pull request Feb 14, 2023
@carlbuchmann @gmuloc @ClausHolbechArista
Fix(eos_cli_config_gen): Relax schema for maintenance unit profile (#…
1dcde3c 
…2492) (#2532)

Co-authored-by: Guillaume Mulocher <gmulocher@arista.com>
Co-authored-by: Claus Holbech <holbech@arista.com>
@gmuloc gmuloc deleted the issue/2488 branch January 17, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlbuchmann carlbuchmann carlbuchmann approved these changes

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

Assignees

@gmuloc gmuloc

Labels
rn: Fix(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
v3.8.2
Development

Successfully merging this pull request may close these issues.

Unnecessary warning on data for AVD 3.8.1
3 participants
@gmuloc @carlbuchmann @ClausHolbechArista