Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_designs): User defined descriptions on l3_edge and core_interfaces #2499

Merged
merged 2 commits into from
Feb 10, 2023
Merged

Feat(eos_designs): User defined descriptions on l3_edge and core_interfaces #2499

merged 2 commits into from
Feb 10, 2023

Conversation

ClausHolbechArista
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista commented Feb 8, 2023 •
edited
Loading

Change Summary

User defined descriptions on l3_edge and core_interfaces

Related Issue(s)

Fixes #

Component(s) name

arista.avd.eos_designs

Proposed changes

l3_edge:
  p2p_links:
    - <...>
     
      # Interface Description | Optional
      descriptions: [ < node_a_description >, < node_b_description > ]

core_interfaces:
  p2p_links:
    - <...>
     
      # Interface Description | Optional
      descriptions: [ < node_a_description >, < node_b_description > ]

How to test

Added molecule coverage.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@ClausHolbechArista ClausHolbechArista requested a review from a team as a code owner February 8, 2023 13:56
@github-actions github-actions bot added role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Feb 8, 2023
@ClausHolbechArista ClausHolbechArista added this to the v4.0.0-dev3 milestone Feb 8, 2023
emilarista
emilarista approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@emilarista emilarista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

gmuloc
gmuloc reviewed Feb 9, 2023
View reviewed changes
ansible_collections/arista/avd/roles/eos_designs/python_modules/core_interfaces/utils.py Outdated
@@ -210,6 +212,7 @@ def _get_p2p_data(self, p2p_link: dict) -> dict:
"peer_ip": ip[peer_index],
"bgp_as": str(bgp_as[index]),
"peer_bgp_as": str(bgp_as[peer_index]),
"description": descriptions[index] if descriptions[index] is not None else None,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so ... :) this could just be "description": descriptions[index] right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha, yes. Fixed.

carlbuchmann
carlbuchmann approved these changes Feb 10, 2023
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann merged commit a7126b3 into aristanetworks:devel Feb 10, 2023
@ClausHolbechArista ClausHolbechArista deleted the custom-descriptions-on-l3edge-and-core-interfaces branch January 24, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmuloc gmuloc gmuloc left review comments

@carlbuchmann carlbuchmann carlbuchmann approved these changes

@emilarista emilarista emilarista approved these changes

Assignees

@ClausHolbechArista ClausHolbechArista

Labels
rn: Feat(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
v4.0.0-dev3
Development

Successfully merging this pull request may close these issues.
4 participants
@ClausHolbechArista @gmuloc @carlbuchmann @emilarista