Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ip-helper for dhcp-relay #345

Merged
merged 4 commits into from
Nov 16, 2020
Merged

Implement ip-helper for dhcp-relay #345

merged 4 commits into from
Nov 16, 2020

Conversation

titom73
Copy link
Contributor

@titom73 titom73 commented Nov 3, 2020

Change Summary

Apply data model from eos_cli_config_gen in eos_l3ls_evpn

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Documentation content changes
  • Other (please describe):

Related Issue(s)

Fixes #312

Component(s) name

eos_l3ls_evpn

Proposed changes

Apply data model from eos_cli_config_gen in eos_l3ls_evpn

tenants:
  # Tenant A Specific Information - VRFs / VLANs
  Tenant_A:
    mac_vrf_vni_base: 10000
    vrfs:
      TENANT_A_PROJECT01:
        vrf_vni: 11
        svis:
          311:
            name: 'PR01-TRUST-DHCP'
            tags: [POD01]
            enabled: true
            ip_address_virtual: 10.1.31.254/24
            ip_helpers:
              1.1.1.1:
                source_interface: lo100
  Tenant_B:
    mac_vrf_vni_base: 11000
    vrfs:
      ip_helpers:
        1.1.1.1:
          source_interface: lo100
      TENANT_B_PROJECT01:
        vrf_vni: 12
        svis:
          311:
            name: 'PR01-TRUST-DHCP'
            tags: [POD01]
            enabled: true
            ip_address_virtual: 10.2.31.254/24

How to test

Rendering is as below for eos_cli_config_gen:

  Vlan311:
    tenant: Tenant_A
    tags: ['POD01']
    description: PR01-TRUST-DHCP
    vrf: TENANT_A_PROJECT01
    ip_address_virtual: 10.1.31.254/24
    ip_helpers:
      1.1.1.1:
        source_interface: lo100
        vrf: TENANT_A_PROJECT01

And EOS configuration:

interface Vlan311
   description PR01-TRUST-DHCP
   vrf TENANT_A_PROJECT01
   ip address virtual 10.1.31.254/24
   ip helper-address 1.1.1.1 vrf TENANT_A_PROJECT01  source-interface lo100

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have updated molecule CI testing accordingly
  • I have read the CONTRIBUTING document.
  • All new and existing tests passed (pre-commit, make linting and make sanity-lint).

Apply data model from eos_cli_config_gen in eos_l3ls_evpn

```
tenants:
  # Tenant A Specific Information - VRFs / VLANs
  Tenant_A:
    mac_vrf_vni_base: 10000
    vrfs:
      TENANT_A_PROJECT01:
        vrf_vni: 11
        svis:
          311:
            name: 'PR01-TRUST-DHCP'
            tags: [POD01]
            enabled: true
            ip_address_virtual: 10.1.31.254/24
            ip_helpers:
              1.1.1.1:
                source_interface: lo100
```

Rendering is as below for eos_cli_config_gen:

```
  Vlan311:
    tenant: Tenant_A
    tags: ['POD01']
    description: PR01-TRUST-DHCP
    vrf: TENANT_A_PROJECT01
    ip_address_virtual: 10.1.31.254/24
    ip_helpers:
      1.1.1.1:
        source_interface: lo100
        vrf: TENANT_A_PROJECT01
```

And EOS configuration:

```
interface Vlan311
   description PR01-TRUST-DHCP
   vrf TENANT_A_PROJECT01
   ip address virtual 10.1.31.254/24
   ip helper-address 1.1.1.1 vrf TENANT_A_PROJECT01  source-interface lo100
```
@titom73 titom73 self-assigned this Nov 3, 2020
@titom73 titom73 changed the title Implement ip-helper for dhcp-relay #312 Implement ip-helper for dhcp-relay Nov 3, 2020
@github-actions github-actions bot added role: eos_l3ls_evpn issue related to eos_l3ls_evpn role type: documentation Improvements or additions to documentation labels Nov 3, 2020
@carlbuchmann
Copy link
Member

@titom73 - one of the ideas I had regarding the eos_lsls_evpn data model for SVIs, is to implement hierarchical profiles configuration as the configuration might be repetitive across many interfaces.

@titom73
Copy link
Contributor Author

titom73 commented Nov 5, 2020

  • Add support for source_vrf outside of SVI vrf.

Add knob to support source VRF to originate packets. If not set, current
VRF is used
@titom73
Copy link
Contributor Author

titom73 commented Nov 5, 2020

Ready for testing and review

@titom73 titom73 mentioned this pull request Nov 6, 2020
14 tasks
@titom73 titom73 added this to the v1.1.1 milestone Nov 16, 2020
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann merged commit 3f727f0 into aristanetworks:devel Nov 16, 2020
@titom73 titom73 deleted the issues/312 branch January 13, 2021 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
role: eos_l3ls_evpn issue related to eos_l3ls_evpn role type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DHCP relay (ip helper-address) in overlay with EVPN
2 participants