-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_cli_config_gen): Add support for MACsec fallback to unprotected traffic #4028
Merged
ClausHolbechArista
merged 6 commits into
aristanetworks:devel
from
Shivani-gslab:mac_sec_traffic
Jun 3, 2024
Merged
Feat(eos_cli_config_gen): Add support for MACsec fallback to unprotected traffic #4028
ClausHolbechArista
merged 6 commits into
aristanetworks:devel
from
Shivani-gslab:mac_sec_traffic
Jun 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4028
# Activate the virtual environment
source test-avd-pr-4028/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Shivani-gslab/avd.git@mac_sec_traffic#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Shivani-gslab/avd.git#/ansible_collections/arista/avd/,mac_sec_traffic --force
# Optional: Install AVD examples
cd test-avd-pr-4028
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
role: eos_designs
issue related to eos_designs role
labels
May 23, 2024
Vibhu-gslab
requested changes
May 23, 2024
...ections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/mac_security.schema.yml
Outdated
Show resolved
Hide resolved
.../arista/avd/molecule/eos_cli_config_gen/documentation/devices/mac-security-eth-po-entropy.md
Show resolved
Hide resolved
Shivani-gslab
force-pushed
the
mac_sec_traffic
branch
2 times, most recently
from
May 24, 2024 13:20
93524ed
to
52d0c87
Compare
Shivani-gslab
force-pushed
the
mac_sec_traffic
branch
from
May 27, 2024 05:09
52d0c87
to
b35203c
Compare
Vibhu-gslab
approved these changes
May 28, 2024
ClausHolbechArista
requested changes
May 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments. Otherwise looks good to me.
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/mac-security.j2
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/mac-security.j2
Outdated
Show resolved
Hide resolved
Vibhu-gslab
changed the title
Feat(eos_cli_config_gen): Add support for MACsec fallback to unprotected traffic.
Feat(eos_cli_config_gen): Add support for MACsec fallback to unprotected traffic
May 29, 2024
MaheshGSLAB
approved these changes
May 30, 2024
MaheshGSLAB
reviewed
May 30, 2024
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/mac-security.j2
Outdated
Show resolved
Hide resolved
Co-authored-by: Claus Holbech <holbech@arista.com>
Shivani-gslab
force-pushed
the
mac_sec_traffic
branch
from
May 30, 2024 12:32
99a8895
to
32a34d7
Compare
MaheshGSLAB
approved these changes
Jun 3, 2024
gmuloc
approved these changes
Jun 3, 2024
gmuloc
added
the
one approval
This PR has one approval and is only missing one more.
label
Jun 3, 2024
ClausHolbechArista
approved these changes
Jun 3, 2024
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
one approval
This PR has one approval and is only missing one more.
rn: Feat(eos_cli_config_gen)
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
role: eos_designs
issue related to eos_designs role
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Add support for MACsec fallback to unprotected traffic.
Related Issue(s)
Fixes #3696
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
Adding
traffic_unprotected
tomac_security
data-model-How to test
Molecule test and test on EOS.
Checklist
PR Checklist
Repository Checklist