Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Add support for MACsec fallback to unprotected traffic #4028

Merged

Conversation

Shivani-gslab
Copy link
Contributor

@Shivani-gslab Shivani-gslab commented May 23, 2024

Change Summary

Add support for MACsec fallback to unprotected traffic.

Related Issue(s)

Fixes #3696

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Adding traffic_unprotected to mac_security data-model-

mac_security:
       traffic_unprotected:

            # Allow/drop the transmit/receive of unprotected traffic.
            action: <str; "allow" | "drop"; required>

            # Allow transmit/receive of encrypted traffic using operational SAK and block otherwise.
            allow_active_sak: <bool>

How to test

Molecule test and test on EOS.

Checklist

PR Checklist

  • Check the command ordering on EOS.

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4028
# Activate the virtual environment
source test-avd-pr-4028/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Shivani-gslab/avd.git@mac_sec_traffic#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Shivani-gslab/avd.git#/ansible_collections/arista/avd/,mac_sec_traffic --force
# Optional: Install AVD examples
cd test-avd-pr-4028
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels May 23, 2024
@Vibhu-gslab Vibhu-gslab marked this pull request as ready for review May 28, 2024 13:19
@Vibhu-gslab Vibhu-gslab requested review from a team as code owners May 28, 2024 13:19
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments. Otherwise looks good to me.

@Vibhu-gslab Vibhu-gslab changed the title Feat(eos_cli_config_gen): Add support for MACsec fallback to unprotected traffic. Feat(eos_cli_config_gen): Add support for MACsec fallback to unprotected traffic May 29, 2024
@MaheshGSLAB MaheshGSLAB self-requested a review May 30, 2024 11:03
@Shivani-gslab Shivani-gslab marked this pull request as draft May 30, 2024 12:19
@Shivani-gslab Shivani-gslab marked this pull request as ready for review May 30, 2024 12:52
@gmuloc gmuloc added the one approval This PR has one approval and is only missing one more. label Jun 3, 2024
Copy link

sonarcloud bot commented Jun 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ClausHolbechArista ClausHolbechArista merged commit 59f6747 into aristanetworks:devel Jun 3, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for MACsec fallback to unprotected traffic
5 participants