-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_designs): Disable per interface MTU for 7010TX #4053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4053
# Activate the virtual environment
source test-avd-pr-4053/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/xaviramon/ansible-avd.git@new_platforms_mlag#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/xaviramon/ansible-avd.git#/ansible_collections/arista/avd/,new_platforms_mlag --force
# Optional: Install AVD examples
cd test-avd-pr-4053
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
state: Documentation role Updated
role: eos_designs
issue related to eos_designs role
labels
May 30, 2024
github-actions
bot
added
the
state: CI Updated
CI scenario have been updated in the PR
label
May 30, 2024
EDIT: not solved |
ansible_collections/arista/avd/plugins/plugin_utils/eos_designs_shared_utils/platform.py
Outdated
Show resolved
Hide resolved
xaviramon
changed the title
Feat(eos_designs): Disable per interface MTU for platforms not suppor…
Feat(eos_designs): Disable per interface MTU for 7010TX
May 30, 2024
ClausHolbechArista
requested changes
May 31, 2024
ansible_collections/arista/avd/molecule/eos_designs_unit_tests/intended/configs/750-LEAF.cfg
Outdated
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
ClausHolbechArista
approved these changes
Jun 3, 2024
ClausHolbechArista
added
the
one approval
This PR has one approval and is only missing one more.
label
Jun 3, 2024
gmuloc
approved these changes
Jun 3, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
one approval
This PR has one approval and is only missing one more.
rn: Feat(eos_designs)
role: eos_designs
issue related to eos_designs role
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
On the 7010TX platform, not using the
per_interface_mtu: false
setting, will generate an incorrect MTU configuration in some interfaces, which is not supported on T3.x1, x2 and x4. This brakes MLAG configuration on these devices.This is not considered a breaking change since using the defined platforms today generates a broken configuration.
Related Issue(s)
Partial fix of #4037
Component(s) name
arista.avd.eos_designs
Proposed changes
Creating a new platform setting for 7010TX, setting
per_interface_mtu
to false.How to test
molecule
Checklist
User Checklist
Repository Checklist