Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_designs): Disable per interface MTU for 7010TX #4053

Merged
merged 8 commits into from
Jun 3, 2024

Conversation

xaviramon
Copy link
Contributor

@xaviramon xaviramon commented May 30, 2024

Change Summary

On the 7010TX platform, not using the per_interface_mtu: false setting, will generate an incorrect MTU configuration in some interfaces, which is not supported on T3.x1, x2 and x4. This brakes MLAG configuration on these devices.

This is not considered a breaking change since using the defined platforms today generates a broken configuration.

Related Issue(s)

Partial fix of #4037

Component(s) name

arista.avd.eos_designs

Proposed changes

Creating a new platform setting for 7010TX, setting per_interface_mtu to false.

How to test

molecule

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4053
# Activate the virtual environment
source test-avd-pr-4053/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/xaviramon/ansible-avd.git@new_platforms_mlag#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/xaviramon/ansible-avd.git#/ansible_collections/arista/avd/,new_platforms_mlag --force
# Optional: Install AVD examples
cd test-avd-pr-4053
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label May 30, 2024
@xaviramon xaviramon marked this pull request as ready for review May 30, 2024 09:11
@xaviramon xaviramon requested review from a team as code owners May 30, 2024 09:11
@xaviramon
Copy link
Contributor Author

xaviramon commented May 30, 2024

EDIT: not solved
Also solving #3123 here

@xaviramon xaviramon changed the title Feat(eos_designs): Disable per interface MTU for platforms not suppor… Feat(eos_designs): Disable per interface MTU for 7010TX May 30, 2024
Copy link

sonarcloud bot commented May 31, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.2% Duplication on New Code

See analysis details on SonarCloud

@ClausHolbechArista ClausHolbechArista requested a review from a team June 3, 2024 13:47
@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Jun 3, 2024
@gmuloc gmuloc merged commit 514236b into aristanetworks:devel Jun 3, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Feat(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants