Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_cli_config_gen): Add support to configure PEG DR election algorithm #4095

Merged
merged 13 commits into from
Jul 23, 2024
Merged

Feat(eos_cli_config_gen): Add support to configure PEG DR election algorithm #4095

merged 13 commits into from
Jul 23, 2024

Conversation

laxmikantchintakindi
Copy link
Contributor

@laxmikantchintakindi laxmikantchintakindi commented Jun 11, 2024 •
edited
Loading

Change Summary

Configuring other PEG DR elections under evpn multicast address family.

Related Issue(s)

Fixes #3787

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Configuring other PEG DR elections under evpn multicast address family.

vrf X      
  evpn multicast
         gateway dr election algorithm modulus / hrw / preference

How to test

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions GitHub Actions
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4095
# Activate the virtual environment
source test-avd-pr-4095/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/laxmikantchintakindi/avd.git@dr_election_algorithm#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/laxmikantchintakindi/avd.git#/ansible_collections/arista/avd/,dr_election_algorithm --force
# Optional: Install AVD examples
cd test-avd-pr-4095
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Jun 11, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@laxmikantchintakindi laxmikantchintakindi marked this pull request as ready for review June 14, 2024 10:27
@ClausHolbechArista
Copy link
Contributor

Moving to draft until the comments have been addressed. Thanks.

@ClausHolbechArista ClausHolbechArista marked this pull request as draft June 17, 2024 12:43
@github-actions github-actions bot added the state: conflict PR with conflict label Jun 19, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added type: documentation Improvements or additions to documentation filter: is_in_filter issue related to is_in_filter plugin type: code quality CI and development toolset role: eos_validate_state type: Python filters labels Jun 21, 2024
@github-actions github-actions bot removed type: documentation Improvements or additions to documentation filter: is_in_filter issue related to is_in_filter plugin type: code quality CI and development toolset labels Jun 21, 2024
@MaheshGSLAB MaheshGSLAB marked this pull request as ready for review June 28, 2024 06:48
Vibhu-gslab
Vibhu-gslab requested changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@Vibhu-gslab Vibhu-gslab left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change rest looks good.

python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/router_bgp.schema.yml Outdated Show resolved Hide resolved
Vibhu-gslab
Vibhu-gslab approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@Vibhu-gslab Vibhu-gslab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gmuloc
Copy link
Contributor

gmuloc commented Jul 2, 2024 •
edited by ClausHolbechArista
Loading

@dgonzalez85 can you please take a look as you opened the issue?

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ClausHolbechArista ClausHolbechArista merged commit ac5a59a into aristanetworks:devel Jul 23, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaheshGSLAB MaheshGSLAB MaheshGSLAB approved these changes

@Vibhu-gslab Vibhu-gslab Vibhu-gslab approved these changes

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

@dgonzalez85 dgonzalez85 Awaiting requested review from dgonzalez85

Assignees

@laxmikantchintakindi laxmikantchintakindi

Labels
rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

eos_cli_config_gen: Add support to configure PEG DR election algorithm
5 participants
@laxmikantchintakindi @ClausHolbechArista @gmuloc @Vibhu-gslab @MaheshGSLAB