Refactor(plugins): Move jinja filter code for arista.avd.generate_esi to PyAVD #4114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4114
# Activate the virtual environment
source test-avd-pr-4114/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Vibhu-gslab/avd.git@generate_esi#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Vibhu-gslab/avd.git#/ansible_collections/arista/avd/,generate_esi --force
# Optional: Install AVD examples
cd test-avd-pr-4114
ansible-playbook arista.avd.install_examples |
MaheshGSLAB
previously approved these changes
Jun 14, 2024
MaheshGSLAB
reviewed
Jun 14, 2024
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
state: conflict
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
ClausHolbechArista
requested changes
Jun 14, 2024
Co-authored-by: laxmikantchintakindi <159624484+laxmikantchintakindi@users.noreply.github.com>
Vibhu-gslab
force-pushed
the
generate_esi
branch
from
411a5cb
to
000b9b3
Compare
ClausHolbechArista
approved these changes
Jun 14, 2024
ClausHolbechArista
added
the
one approval
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Move jinja filter code for arista.avd.generate_esi to PyAVD
Related Issue(s)
Fixes #4113
Component(s) name
arista.avd.generate_esiProposed changes
Moving the code and unit tests for arista.avd.generate_esi filter to PyAVD
How to test
CI should catch things.
Checklist
Repository Checklist