Refactor(eos_cli_config_gen): Move eos_cli_config_gen to pyavd #4117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4117
# Activate the virtual environment
source test-avd-pr-4117/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/gmuloc/avd.git@move-eos-cli-config-gen-pyavd#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/gmuloc/avd.git#/ansible_collections/arista/avd/,move-eos-cli-config-gen-pyavd --force
# Optional: Install AVD examples
cd test-avd-pr-4117
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
type: documentation
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
gmuloc
commented
Jun 14, 2024
...ble_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/custom-templates.cfg
Outdated
Show resolved
Hide resolved
gmuloc
commented
Jun 14, 2024
ansible_collections/arista/avd/plugins/plugin_utils/utils/python_to_ansible_logging_handler.py
Outdated
Show resolved
Hide resolved
gmuloc
commented
Jun 14, 2024
|
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/MOVED_TO_PYAVD.txt
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/MOVED_TO_PYAVD.txt
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/tasks/main.yml
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/tasks/main.yml
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/plugins/action/eos_cli_config_gen.py
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/plugins/modules/eos_cli_config_gen.py
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/plugins/plugin_utils/utils/python_to_ansible_logging_handler.py
Outdated
Show resolved
Hide resolved
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
...vd/molecule/eos_cli_config_gen_negative_unit_tests/inventory/host_vars/hardware-counters.yml
Show resolved
Hide resolved
ClausHolbechArista
approved these changes
Jun 19, 2024
ClausHolbechArista
added
the
one approval
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/MOVED_TO_PYAVD.txt
Outdated
Show resolved
Hide resolved
…tes/MOVED_TO_PYAVD.txt Co-authored-by: Carl Buchmann <carl.buchmann@arista.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Move eos_cli_config_gen to PyAVD
Component(s) name
pyavdProposed changes
How to test
molecule goes through
Checklist
User Checklist
introduced a pre-commit hook. Probably need to document how to use it as it has some caveat (e.g. if you make a change, compile via the hook, rollback the change and use pre-commit, nothing happens because no change to j2 as compared to HEAD)
Repository Checklist