Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues SVI state not applied & management ssh vrf #415

Merged
merged 4 commits into from
Dec 8, 2020
Merged

Fix issues SVI state not applied & management ssh vrf #415

merged 4 commits into from
Dec 8, 2020

Conversation

carlbuchmann
Copy link
Member

@carlbuchmann carlbuchmann commented Dec 4, 2020 •
edited
Loading

Change Summary

Update templates in eos_l3ls_evpn and eos_cli_config gen to resolve issues.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Documentation content changes
  • Other (please describe):

Related Issue(s)

resolves #352 #409

How to test

View molecule CI artifacts

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed (pre-commit, make linting and make sanity-lint).
  • I have updated molecule CI testing accordingly

@github-actions github-actions bot added role: eos_l3ls_evpn issue related to eos_l3ls_evpn role state: CI Updated CI scenario have been updated in the PR type: documentation Improvements or additions to documentation labels Dec 4, 2020
@carlbuchmann carlbuchmann mentioned this pull request Dec 4, 2020
Closed
@carlbuchmann carlbuchmann marked this pull request as ready for review December 4, 2020 03:23
titom73
titom73 approved these changes Dec 4, 2020
View reviewed changes
Copy link
Contributor

@titom73 titom73 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but not seeing #409 fix

@titom73 titom73 added the type: bug Something isn't working label Dec 6, 2020
@titom73 titom73 added this to the v1.1.2 milestone Dec 6, 2020
@aphillipps
Copy link
Contributor

LGTM

aphillipps
aphillipps approved these changes Dec 8, 2020
View reviewed changes
Copy link
Contributor

@aphillipps aphillipps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann merged commit 2726ba9 into aristanetworks:devel Dec 8, 2020
@carlbuchmann carlbuchmann deleted the fix-352-409 branch December 8, 2020 17:43
@titom73 titom73 mentioned this pull request Feb 15, 2022
Merged
@titom73 titom73 mentioned this pull request Mar 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aphillipps aphillipps aphillipps approved these changes

@titom73 titom73 titom73 approved these changes

Assignees

@carlbuchmann carlbuchmann

Labels
role: eos_l3ls_evpn issue related to eos_l3ls_evpn role state: CI Updated CI scenario have been updated in the PR type: bug Something isn't working type: documentation Improvements or additions to documentation
Projects
None yet
Milestone
v1.1.2
Development

Successfully merging this pull request may close these issues.

SVI State not applied to configuration
3 participants
@carlbuchmann @aphillipps @titom73