Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_designs): Add keys to set loopback0 and vtep_loopback directly #4168

Merged
merged 12 commits into from
Jul 26, 2024

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Jul 1, 2024

Change Summary

Add two node level keys

loopback_ipv4_address and vtep_loopback_ipv4_address to have a better way of settings these rather than using the pools with the offset trick of -1

Related Issue(s)

Fixes #2719

Component(s) name

arista.avd.eos_designs

Proposed changes

  • The two keys take precedence over the _pool version
  • AVD does not check if they are unique (or valid - it only knows them as string)

How to test

molecule test added

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gmuloc gmuloc requested review from a team as code owners July 1, 2024 12:34
Copy link

github-actions bot commented Jul 1, 2024

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4168
# Activate the virtual environment
source test-avd-pr-4168/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/gmuloc/avd.git@issue/2719#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/gmuloc/avd.git#/ansible_collections/arista/avd/,issue/2719 --force
# Optional: Install AVD examples
cd test-avd-pr-4168
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Jul 1, 2024
@laxmikantchintakindi laxmikantchintakindi changed the title Feat(eos_designs): Add keys to set oopback0 and vtep_loopback directly Feat(eos_designs): Add keys to set loopback0 and vtep_loopback directly Jul 1, 2024
@gmuloc gmuloc requested review from ClausHolbechArista and a team July 2, 2024 07:26
Co-authored-by: Claus Holbech <holbech@arista.com>
@gmuloc gmuloc requested review from ClausHolbechArista and a team July 2, 2024 08:05
@jmussmann
Copy link
Contributor

Thank you for implementing this.
I tested the pull requested with my desired inventory. It works, but there are more ip pools which should be overridable.

In my fork (jmussmann@b6d177f) I added support for:

  • mlag_peer_ipv4_pool
  • mlag_peer_l3_ipv4_pool

@gmuloc
Copy link
Contributor Author

gmuloc commented Jul 11, 2024

Thank you for implementing this. I tested the pull requested with my desired inventory. It works, but there are more ip pools which should be overridable.

In my fork (jmussmann@b6d177f) I added support for:

  • mlag_peer_ipv4_pool
  • mlag_peer_l3_ipv4_pool

let's open another issue and PR for these two as they are not targeted by the issue

@jmussmann
Copy link
Contributor

Thank you for implementing this. I tested the pull requested with my desired inventory. It works, but there are more ip pools which should be overridable.
In my fork (jmussmann@b6d177f) I added support for:

  • mlag_peer_ipv4_pool
  • mlag_peer_l3_ipv4_pool

let's open another issue and PR for these two as they are not targeted by the issue

Ok, i will open another issue and a PR

@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Jul 22, 2024
@ClausHolbechArista ClausHolbechArista requested a review from a team July 22, 2024 13:30
@gmuloc gmuloc added this to the v4.10.0 milestone Jul 26, 2024
@MaheshGSLAB MaheshGSLAB requested a review from a team July 26, 2024 09:21
Copy link

sonarcloud bot commented Jul 26, 2024

@ClausHolbechArista ClausHolbechArista merged commit deb490f into aristanetworks:devel Jul 26, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Feat(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat(eos_designs): Create knobs to statically set loopback ips for every pool
4 participants