-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_designs): Add keys to set loopback0 and vtep_loopback directly #4168
Conversation
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4168
# Activate the virtual environment
source test-avd-pr-4168/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/gmuloc/avd.git@issue/2719#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/gmuloc/avd.git#/ansible_collections/arista/avd/,issue/2719 --force
# Optional: Install AVD examples
cd test-avd-pr-4168
ansible-playbook arista.avd.install_examples |
...e_collections/arista/avd/molecule/eos_designs_unit_tests/inventory/group_vars/DC1_FABRIC.yml
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/schema/schema_fragments/defs_node_type.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/schema/schema_fragments/defs_node_type.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/schema/schema_fragments/defs_node_type.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/schema/schema_fragments/defs_node_type.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/schema/schema_fragments/defs_node_type.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/schema/schema_fragments/defs_node_type.schema.yml
Outdated
Show resolved
Hide resolved
Co-authored-by: Claus Holbech <holbech@arista.com>
python-avd/pyavd/_eos_designs/schema/schema_fragments/defs_node_type.schema.yml
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/schema/schema_fragments/defs_node_type.schema.yml
Show resolved
Hide resolved
Thank you for implementing this. In my fork (jmussmann@b6d177f) I added support for:
|
let's open another issue and PR for these two as they are not targeted by the issue |
Ok, i will open another issue and a PR |
Quality Gate passedIssues Measures |
Change Summary
Add two node level keys
loopback_ipv4_address
andvtep_loopback_ipv4_address
to have a better way of settings these rather than using the pools with the offset trick of -1Related Issue(s)
Fixes #2719
Component(s) name
arista.avd.eos_designs
Proposed changes
_pool
versionHow to test
molecule test added
Checklist
Repository Checklist