-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_cli_config_gen): Add TLS options for radius_server #4194
Conversation
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4194
# Activate the virtual environment
source test-avd-pr-4194/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/nnbruce/avd.git@fix_issue_4175#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/nnbruce/avd.git#/ansible_collections/arista/avd/,fix_issue_4175 --force
# Optional: Install AVD examples
cd test-avd-pr-4194
ansible-playbook arista.avd.install_examples |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the PR - and for implementing the molecule tests. I have reviewed and required a couple of changes but the PR is almost ready. Please reach out if you need help
python-avd/pyavd/_eos_cli_config_gen/schema/eos_cli_config_gen.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/eos_cli_config_gen.schema.yml
Outdated
Show resolved
Hide resolved
...le_collections/arista/avd/molecule/eos_cli_config_gen/documentation/devices/radius-server.md
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/eos_cli_config_gen.schema.yml
Show resolved
Hide resolved
Thank you for the great feedback. I think I've resolved everything. Let me know if you think we should change something else. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. |
Change Summary
Enhance radius_server functionality by implementing TLS (RadSec) support.
Related Issue(s)
Fixes #4175
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
Adhering to EOS syntax, its possible to only enable TLS for a radius-server, in that case the global ssl-profile is used. In addition it should also be possible to specify a ssl-profile per radius-server. Also added the option to specify TCP Port if using TLS, might be useful if not using AGNI.
If TLS is enabled, we should no longer render key for that specific radius-server.
Any suggestions to make the data model better is appreciated.
How to test
Tested with DevContainer and Molecule. Molecule generated config tested on EOS.
Checklist
User Checklist
Repository Checklist