Fix: Incorrect default value for 720XP for trident_forwarding_table_partition #4215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4215
# Activate the virtual environment
source test-avd-pr-4215/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/carlbuchmann/avd.git@fix-720XP-trident-forward-table-partition-default-value#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/carlbuchmann/avd.git#/ansible_collections/arista/avd/,fix-720XP-trident-forward-table-partition-default-value --force
# Optional: Install AVD examples
cd test-avd-pr-4215
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
state: Documentation role Updated
role: eos_designs
ClausHolbechArista
requested changes
Jul 22, 2024
python-avd/pyavd/_eos_designs/schema/schema_fragments/evpn_multicast.schema.yml
Outdated
Show resolved
Hide resolved
…ticast.schema.yml
gmuloc
approved these changes
Jul 22, 2024
for more information, see https://pre-commit.ci
ClausHolbechArista
approved these changes
Jul 23, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
trident_forwarding_table_partition: "flexible exact-match 16384 l2-shared 98304 l3-shared 131072"command on the 720XP is not valid because the table sizes differ from the 7050X platforms the original default was based on.New suggested default:
trident_forwarding_table_partition: "flexible exact-match 16000 l2-shared 18000 l3-shared 22000.