-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_cli_config_gen): Add MPLS Tunnel Support for Traceroute and PMTU Discovery #4219
Conversation
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4219
# Activate the virtual environment
source test-avd-pr-4219/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Shivani-gslab/avd.git@mpls_tunnel#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Shivani-gslab/avd.git#/ansible_collections/arista/avd/,mpls_tunnel --force
# Optional: Install AVD examples
cd test-avd-pr-4219
ansible-playbook arista.avd.install_examples |
LGTM |
@dgonzalez85 can you please confirm thats what is needed. Also I found indication that |
ansible_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/mpls.cfg
Outdated
Show resolved
Hide resolved
Looks good! I will test. As we've discussed, MPLS support was mainly in Jericho-based platforms, but seems there are some basic in strata as well: https://www.arista.com/en/support/toi/eos-4-23-0f/14327-mpls-support-on-x-series-switches. So good to add a note to review platform support. thanks! |
Thanks @dgonzalez85 - @Shivani-gslab after some thought we are not putting everywhere "this is platform dependent" (e.g. for the command only supported on CloudEOS) so I would leave it as it is. |
4d3e2fd
to
6cf5c89
Compare
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/mpls-and-ldp.j2
Outdated
Show resolved
Hide resolved
Co-authored-by: Guillaume Mulocher <gmulocher@arista.com>
Co-authored-by: Claus Holbech <holbech@arista.com>
98efa06
to
db5ff0d
Compare
Quality Gate passedIssues Measures |
Change Summary
Add MPLS Tunnel Support for Traceroute and PMTU Discovery
Related Issue(s)
Fixes #4185
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
Implementing schema and template for -
How to test
Test in EOS CLI and the molecule tests in this PR.
Checklist
Self review Checklist
Repository Checklist