Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Add MPLS Tunnel Support for Traceroute and PMTU Discovery #4219

Merged
merged 9 commits into from
Jul 23, 2024

Conversation

Shivani-gslab
Copy link
Contributor

@Shivani-gslab Shivani-gslab commented Jul 16, 2024

Change Summary

Add MPLS Tunnel Support for Traceroute and PMTU Discovery

Related Issue(s)

Fixes #4185

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Implementing schema and template for -

mpls icmp fragmentation-needed tunneling
mpls icmp ttl-exceeded tunneling 

How to test

Test in EOS CLI and the molecule tests in this PR.

Checklist

Self review Checklist

  • Order of config should be as per EOS cli.
  • Add exclamatory marks(!) at correct position in templates. It should be same as reflected in run-config.
  • Verify the changes by running pre-commit and all molecules.
  • Along with EOS config template, update the documentation template as well (if required).
  • Add the test-case in molecules for any new data-model/key/fix.
  • Add description to the keys as per the docs.
  • Add punctuation to all descriptions.

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4219
# Activate the virtual environment
source test-avd-pr-4219/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Shivani-gslab/avd.git@mpls_tunnel#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Shivani-gslab/avd.git#/ansible_collections/arista/avd/,mpls_tunnel --force
# Optional: Install AVD examples
cd test-avd-pr-4219
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Jul 16, 2024
@laxmikantchintakindi
Copy link
Contributor

LGTM

@laxmikantchintakindi laxmikantchintakindi marked this pull request as ready for review July 18, 2024 05:57
@gmuloc
Copy link
Contributor

gmuloc commented Jul 18, 2024

@dgonzalez85 can you please confirm thats what is needed. Also I found indication that
Command mpls icmp fragmentation-needed tunneling is not implemented in all platforms. Can you please confirm as it probably should go in the description

@dgonzalez85
Copy link

m thats what is needed. Also I found indication th

Looks good! I will test. As we've discussed, MPLS support was mainly in Jericho-based platforms, but seems there are some basic in strata as well: https://www.arista.com/en/support/toi/eos-4-23-0f/14327-mpls-support-on-x-series-switches. So good to add a note to review platform support. thanks!

@Shivani-gslab Shivani-gslab marked this pull request as draft July 19, 2024 05:12
@gmuloc
Copy link
Contributor

gmuloc commented Jul 19, 2024

m thats what is needed. Also I found indication th

Looks good! I will test. As we've discussed, MPLS support was mainly in Jericho-based platforms, but seems there are some basic in strata as well: https://www.arista.com/en/support/toi/eos-4-23-0f/14327-mpls-support-on-x-series-switches. So good to add a note to review platform support. thanks!

Thanks @dgonzalez85 - @Shivani-gslab after some thought we are not putting everywhere "this is platform dependent" (e.g. for the command only supported on CloudEOS) so I would leave it as it is.

@Shivani-gslab Shivani-gslab force-pushed the mpls_tunnel branch 2 times, most recently from 4d3e2fd to 6cf5c89 Compare July 20, 2024 05:58
@Shivani-gslab Shivani-gslab marked this pull request as ready for review July 20, 2024 07:17
python-avd/tox.ini Outdated Show resolved Hide resolved
@Shivani-gslab Shivani-gslab marked this pull request as draft July 22, 2024 11:04
@Shivani-gslab Shivani-gslab marked this pull request as ready for review July 22, 2024 11:26
@ClausHolbechArista ClausHolbechArista requested a review from a team July 23, 2024 05:35
@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Jul 23, 2024
Copy link

sonarcloud bot commented Jul 23, 2024

@gmuloc gmuloc merged commit 0187ec9 into aristanetworks:devel Jul 23, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MPLS Tunnel Support for Traceroute and PMTU Discovery
6 participants