Feat(eos_designs,eos_cli_config_gen): Support for IPv6 on network services VRF diagnostic loopback #4222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4222
# Activate the virtual environment
source test-avd-pr-4222/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Vibhu-gslab/avd.git@vtep_diagnostic_eos_designs#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Vibhu-gslab/avd.git#/ansible_collections/arista/avd/,vtep_diagnostic_eos_designs --force
# Optional: Install AVD examples
cd test-avd-pr-4222
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
role: eos_cli_config_gen
Vibhu-gslab
force-pushed
the
vtep_diagnostic_eos_designs
branch
from
e7113a0
to
90ff525
Compare
python-avd/pyavd/_eos_designs/schema/schema_fragments/defs_network_services.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/schema/schema_fragments/defs_network_services.schema.yml
Outdated
Show resolved
Hide resolved
Vibhu-gslab
force-pushed
the
vtep_diagnostic_eos_designs
branch
2 times, most recently
from
95c1d9f
to
9635bd6
Compare
MaheshGSLAB
reviewed
Jul 24, 2024
ansible_collections/arista/avd/examples/dual-dc-l3ls/documentation/devices/dc1-leaf1a.md
Outdated
Show resolved
Hide resolved
...ollections/arista/avd/molecule/eos_cli_config_gen/inventory/host_vars/virtual-source-nat.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/network_services/loopback_interfaces.py
Outdated
Show resolved
Hide resolved
Vibhu-gslab
force-pushed
the
vtep_diagnostic_eos_designs
branch
2 times, most recently
from
01eead7
to
ac1e857
Compare
MaheshGSLAB
reviewed
Jul 29, 2024
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/virtual-source-nat-vrfs.j2
Show resolved
Hide resolved
Vibhu-gslab
force-pushed
the
vtep_diagnostic_eos_designs
branch
from
ac1e857
to
9208252
Compare
Vibhu-gslab
force-pushed
the
vtep_diagnostic_eos_designs
branch
from
59e41f9
to
fb857ff
Compare
MaheshGSLAB
previously approved these changes
Jul 31, 2024
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
ClausHolbechArista
added
the
one approval
ClausHolbechArista
approved these changes
Nov 11, 2024
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
bjmeuer
approved these changes
Nov 12, 2024
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Add
ipv6 virtual source-nat vrf <vrf>support to eos_cli_config_gen and eos_designs.Related Issue(s)
Fixes #3936 , #4207
Component(s) name
arista.avd.eos_designsarista.avd.eos_cli_config_genProposed changes
Added ipv6 support for virtual source nat vrfs.
How to test
Added test in molecule
Checklist
Repository Checklist