Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(cv_deploy): Add application data to CV Pathfinder metadata #4247

Conversation

ClausHolbechArista
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista commented Jul 24, 2024

Change Summary

Add application data to CV Pathfinder metadata

Component(s) name

arista.avd.eos_designs
arista.avd.cv_deploy

Proposed changes

For CV Pathfinder deployments set metadata for "applications" if supported by CV.

How to test

Tested manually towards a test CV instance.
Tested by systest as well.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4247
# Activate the virtual environment
source test-avd-pr-4247/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ClausHolbechArista/avd.git@feat/cv_deploy/cv-pathfinder-app-data-metadata#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ClausHolbechArista/avd.git#/ansible_collections/arista/avd/,feat/cv_deploy/cv-pathfinder-app-data-metadata --force
# Optional: Install AVD examples
cd test-avd-pr-4247
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Jul 24, 2024
@ClausHolbechArista ClausHolbechArista added this to the v4.10.0 milestone Jul 24, 2024
@ClausHolbechArista ClausHolbechArista force-pushed the feat/cv_deploy/cv-pathfinder-app-data-metadata branch from d827d16 to 74fd81f Compare July 26, 2024 05:58
@ClausHolbechArista ClausHolbechArista marked this pull request as ready for review July 26, 2024 07:42
@ClausHolbechArista ClausHolbechArista requested review from a team as code owners July 26, 2024 07:42
@gmuloc gmuloc added the one approval This PR has one approval and is only missing one more. label Jul 26, 2024
Copy link

sonarcloud bot commented Jul 26, 2024

@ClausHolbechArista ClausHolbechArista merged commit ddb78c0 into aristanetworks:devel Jul 26, 2024
44 checks passed
@gmuloc gmuloc requested a review from a team July 26, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Feat(cv_deploy) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants