-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(cv_deploy): Add application data to CV Pathfinder metadata #4247
Merged
ClausHolbechArista
merged 7 commits into
aristanetworks:devel
from
ClausHolbechArista:feat/cv_deploy/cv-pathfinder-app-data-metadata
Jul 26, 2024
Merged
Feat(cv_deploy): Add application data to CV Pathfinder metadata #4247
ClausHolbechArista
merged 7 commits into
aristanetworks:devel
from
ClausHolbechArista:feat/cv_deploy/cv-pathfinder-app-data-metadata
Jul 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4247
# Activate the virtual environment
source test-avd-pr-4247/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ClausHolbechArista/avd.git@feat/cv_deploy/cv-pathfinder-app-data-metadata#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ClausHolbechArista/avd.git#/ansible_collections/arista/avd/,feat/cv_deploy/cv-pathfinder-app-data-metadata --force
# Optional: Install AVD examples
cd test-avd-pr-4247
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
labels
Jul 24, 2024
ClausHolbechArista
force-pushed
the
feat/cv_deploy/cv-pathfinder-app-data-metadata
branch
from
July 26, 2024 05:58
d827d16
to
74fd81f
Compare
gmuloc
approved these changes
Jul 26, 2024
python-avd/pyavd/_eos_designs/structured_config/network_services/metadata.py
Show resolved
Hide resolved
gmuloc
added
the
one approval
This PR has one approval and is only missing one more.
label
Jul 26, 2024
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
one approval
This PR has one approval and is only missing one more.
rn: Feat(cv_deploy)
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Add application data to CV Pathfinder metadata
Component(s) name
arista.avd.eos_designs
arista.avd.cv_deploy
Proposed changes
For CV Pathfinder deployments set metadata for "applications" if supported by CV.
How to test
Tested manually towards a test CV instance.
Tested by systest as well.
Checklist
User Checklist
Repository Checklist