Refactor(eos_cli_config_gen): Deprecate Upper case letter Vxlan1 to vxlan1 for vxlan_interface schema #4250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4250
# Activate the virtual environment
source test-avd-pr-4250/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/MaheshGSLAB/ansible-avd.git@issue-4244#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/MaheshGSLAB/ansible-avd.git#/ansible_collections/arista/avd/,issue-4244 --force
# Optional: Install AVD examples
cd test-avd-pr-4250
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
role: eos_cli_config_gen
ClausHolbechArista
previously requested changes
Jul 24, 2024
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/vxlan-interface.j2
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/vxlan-interface.j2
Outdated
Show resolved
Hide resolved
|
This deprecation will need to wait for 5.0.0 since it would trigger deprecation warnings for eos_designs run. In 5.0.0 we should change output of eos_designs to use this new key and deprecate the old for removal in 6.0.0. Too bad. |
Co-authored-by: Claus Holbech <holbech@arista.com>
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
ClausHolbechArista
approved these changes
Aug 8, 2024
|
jrecchia1029
pushed a commit
to jrecchia1029/ansible-avd
that referenced
this pull request
Aug 14, 2024
…xlan1 for vxlan_interface schema (aristanetworks#4250)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Deprecate Upper case letter Vxlan1 to vxlan1 for vxlan_interface schema
Related Issue(s)
Fixes #4244
Component(s) name
arista.avd.eos_cli_config_genProposed changes
Deprecate Upper case letter Vxlan1 to vxlan1 for vxlan_interface schema
How to test
Run molecule
Checklist
User Checklist
Repository Checklist