Feat(eos_cli_config_gen): Add support for isis authentication on vlan interfaces #4254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4254
# Activate the virtual environment
source test-avd-pr-4254/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/laxmikantchintakindi/avd.git@isis_auth_vlan_int#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/laxmikantchintakindi/avd.git#/ansible_collections/arista/avd/,isis_auth_vlan_int --force
# Optional: Install AVD examples
cd test-avd-pr-4254
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
role: eos_cli_config_gen
4 tasks
There was a problem hiding this comment.
Can't we directly refer router_isis.authentication schema here, under a single key isis_authentication.
Is there any difference in both the CLI?
@laxmikantchintakindi
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/vlan_interfaces.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/vlan_interfaces.schema.yml
Outdated
Show resolved
Hide resolved
router_isis.authentication cli differs from this. |
laxmikantchintakindi
force-pushed
the
isis_auth_vlan_int
branch
from
b8def65
to
d6d8b9d
Compare
Shivani-gslab
requested changes
Jul 29, 2024
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/vlan-interfaces.j2
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/vlan-interfaces.j2
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/vlan-interfaces.cfg
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/vlan-interfaces.j2
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/vlan-interfaces.j2
Outdated
Show resolved
Hide resolved
laxmikantchintakindi
force-pushed
the
isis_auth_vlan_int
branch
from
fc72801
to
f7ad1e7
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
laxmikantchintakindi
force-pushed
the
isis_auth_vlan_int
branch
from
f7ad1e7
to
ca5c16d
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
laxmikantchintakindi
force-pushed
the
isis_auth_vlan_int
branch
from
ca5c16d
to
b919b12
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
github-actions
bot
added
state: conflict
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
github-actions
bot
added
the
role: eos_cli_config_gen
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Vibhu-gslab
force-pushed
the
isis_auth_vlan_int
branch
from
d7ab9f8
to
c6ce521
Compare
Vibhu-gslab
approved these changes
Aug 19, 2024
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/vlan-interfaces.j2
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/vlan-interfaces.j2
Outdated
Show resolved
Hide resolved
…/vlan-interfaces.j2 Co-authored-by: Shivani-gslab <145646625+Shivani-gslab@users.noreply.github.com>
…/vlan-interfaces.j2 Co-authored-by: Shivani-gslab <145646625+Shivani-gslab@users.noreply.github.com>
Shivani-gslab
approved these changes
Aug 20, 2024
ClausHolbechArista
approved these changes
Aug 20, 2024
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/router_isis.schema.yml
Outdated
Show resolved
Hide resolved
…outer_isis.schema.yml
for more information, see https://pre-commit.ci
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Add support for isis authentication on vlan interfaces. This needs to be merged before PR #4102.
Related Issue(s)
Component(s) name
arista.avd.eos_cli_config_genProposed changes
Add support for isis authentication on vlan interfaces.
How to test
Checklist
User Checklist
Repository Checklist