-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cut(eos_cli_config_gen): Remove the deprecated key local_interface from stun server data model #4274
Merged
ClausHolbechArista
merged 8 commits into
aristanetworks:devel
from
MaheshGSLAB:stun-deprecation
Jul 30, 2024
Merged
Cut(eos_cli_config_gen): Remove the deprecated key local_interface from stun server data model #4274
ClausHolbechArista
merged 8 commits into
aristanetworks:devel
from
MaheshGSLAB:stun-deprecation
Jul 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4274
# Activate the virtual environment
source test-avd-pr-4274/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/MaheshGSLAB/ansible-avd.git@stun-deprecation#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/MaheshGSLAB/ansible-avd.git#/ansible_collections/arista/avd/,stun-deprecation --force
# Optional: Install AVD examples
cd test-avd-pr-4274
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
state: Documentation role Updated
labels
Jul 29, 2024
github-actions
bot
added
the
state: CI Updated
CI scenario have been updated in the PR
label
Jul 29, 2024
laxmikantchintakindi
approved these changes
Jul 29, 2024
MaheshGSLAB
changed the title
Refactor(eos_cli_config_gen): Marked deprecated key local_interface as removed from stun server data model
Refactor(eos_cli_config_gen): Remove the deprecated keys from stun server data model
Jul 29, 2024
Vibhu-gslab
approved these changes
Jul 29, 2024
github-actions
bot
added
the
type: documentation
Improvements or additions to documentation
label
Jul 30, 2024
ClausHolbechArista
changed the title
Refactor(eos_cli_config_gen): Remove the deprecated keys from stun server data model
Cut(eos_cli_config_gen): Remove the deprecated keys from stun server data model
Jul 30, 2024
ClausHolbechArista
changed the title
Cut(eos_cli_config_gen): Remove the deprecated keys from stun server data model
Cut(eos_cli_config_gen): Remove the deprecated key local_interface from stun server data model
Jul 30, 2024
ClausHolbechArista
approved these changes
Jul 30, 2024
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
rn: Cut(eos_cli_config_gen)
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
type: documentation
Improvements or additions to documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Marked deprecated key local_interface as removed from stun server data model
Related Issue(s)
Fixes #
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
Added removed: true for key local_interface and removed the functionality from j2 template
How to test
Run molecule
Checklist
User Checklist
Repository Checklist