Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut(eos_cli_config_gen): Remove the deprecated key local_interface from stun server data model #4274

Merged
merged 8 commits into from
Jul 30, 2024

Conversation

MaheshGSLAB
Copy link
Contributor

Change Summary

Marked deprecated key local_interface as removed from stun server data model

Related Issue(s)

Fixes #

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Added removed: true for key local_interface and removed the functionality from j2 template

How to test

Run molecule

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@MaheshGSLAB MaheshGSLAB self-assigned this Jul 29, 2024
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4274
# Activate the virtual environment
source test-avd-pr-4274/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/MaheshGSLAB/ansible-avd.git@stun-deprecation#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/MaheshGSLAB/ansible-avd.git#/ansible_collections/arista/avd/,stun-deprecation --force
# Optional: Install AVD examples
cd test-avd-pr-4274
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: Documentation role Updated labels Jul 29, 2024
@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Jul 29, 2024
@MaheshGSLAB MaheshGSLAB changed the title Refactor(eos_cli_config_gen): Marked deprecated key local_interface as removed from stun server data model Refactor(eos_cli_config_gen): Remove the deprecated keys from stun server data model Jul 29, 2024
@Vibhu-gslab Vibhu-gslab marked this pull request as ready for review July 29, 2024 12:08
@Vibhu-gslab Vibhu-gslab requested review from a team as code owners July 29, 2024 12:08
@github-actions github-actions bot added the type: documentation Improvements or additions to documentation label Jul 30, 2024
@ClausHolbechArista ClausHolbechArista changed the title Refactor(eos_cli_config_gen): Remove the deprecated keys from stun server data model Cut(eos_cli_config_gen): Remove the deprecated keys from stun server data model Jul 30, 2024
@ClausHolbechArista ClausHolbechArista changed the title Cut(eos_cli_config_gen): Remove the deprecated keys from stun server data model Cut(eos_cli_config_gen): Remove the deprecated key local_interface from stun server data model Jul 30, 2024
Copy link

sonarcloud bot commented Jul 30, 2024

@ClausHolbechArista ClausHolbechArista merged commit 51c08c9 into aristanetworks:devel Jul 30, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Cut(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants