Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cut(eos_cli_config_gen): Remove the deprecated keys for port-channel-interfaces #4297

Merged
merged 6 commits into from
Aug 2, 2024
Merged

Cut(eos_cli_config_gen): Remove the deprecated keys for port-channel-interfaces #4297

merged 6 commits into from
Aug 2, 2024

Conversation

MaheshGSLAB
Copy link
Contributor

Change Summary

Remove the deprecated keys for port-channel-interfaces

Related Issue(s)

Fixes #

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Remove the deprecated keys for port-channel-interfaces

How to test

Run molecule

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@MaheshGSLAB MaheshGSLAB self-assigned this Jul 31, 2024
@github-actions GitHub Actions
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4297
# Activate the virtual environment
source test-avd-pr-4297/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/MaheshGSLAB/ansible-avd.git@port-channel#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/MaheshGSLAB/ansible-avd.git#/ansible_collections/arista/avd/,port-channel --force
# Optional: Install AVD examples
cd test-avd-pr-4297
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added type: documentation Improvements or additions to documentation role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Jul 31, 2024
@MaheshGSLAB MaheshGSLAB marked this pull request as ready for review July 31, 2024 10:26
@MaheshGSLAB MaheshGSLAB requested review from a team as code owners July 31, 2024 10:26
@github-actions github-actions bot added the state: conflict PR with conflict label Jul 31, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the state: conflict PR with conflict label Aug 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 1, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@ClausHolbechArista ClausHolbechArista added this to the v5.0.0-dev1 milestone Aug 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 2, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added state: conflict PR with conflict and removed state: conflict PR with conflict labels Aug 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 2, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 2, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the state: conflict PR with conflict label Aug 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 2, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the state: conflict PR with conflict label Aug 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 2, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

carlbuchmann
carlbuchmann approved these changes Aug 2, 2024
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the state: conflict PR with conflict label Aug 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 2, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the state: conflict PR with conflict label Aug 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 2, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@carlbuchmann carlbuchmann dismissed ClausHolbechArista’s stale review August 2, 2024 15:43

comments have been addressed

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@gmuloc gmuloc merged commit 3ffe991 into aristanetworks:devel Aug 2, 2024
43 checks passed
jrecchia1029 pushed a commit to jrecchia1029/ansible-avd that referenced this pull request Aug 14, 2024
@MaheshGSLAB @carlbuchmann
@ClausHolbechArista @jrecchia1029
Cut(eos_cli_config_gen): Remove the deprecated keys for port-channel-…
5c83137 
…interfaces (aristanetworks#4297)

Co-authored-by: Carl Buchmann <carl.buchmann@arista.com>
Co-authored-by: Claus Holbech <holbech@arista.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laxmikantchintakindi laxmikantchintakindi laxmikantchintakindi approved these changes

@carlbuchmann carlbuchmann carlbuchmann approved these changes

@gmuloc gmuloc gmuloc approved these changes

@ClausHolbechArista ClausHolbechArista Awaiting requested review from ClausHolbechArista

Assignees

@MaheshGSLAB MaheshGSLAB

Labels
rn: Cut(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated type: documentation Improvements or additions to documentation
Projects
None yet
Milestone
v5.0.0-dev1
Development

Successfully merging this pull request may close these issues.
5 participants
@MaheshGSLAB @gmuloc @carlbuchmann @ClausHolbechArista @laxmikantchintakindi