Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut(eos_cli_config_gen,eos_designs): Remove deprecated jsonschema files #4299

Merged
merged 3 commits into from
Jul 31, 2024

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Jul 31, 2024

Change Summary

cf title

Related Issue(s)

Addressing 5.0.0 tasklist point, deprecation indicating the removal of these jsonschema files was push in AVD 4.10

Component(s) name

arista.avd.eos_cli_config_gen, arista.avd.eos_designs

Proposed changes

Remove the code generating the jsonschemas from the AVD schema

How to test

jsonschemas are not rebuilt.

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gmuloc gmuloc requested review from a team as code owners July 31, 2024 10:03
@gmuloc gmuloc added this to the v5.0.0-dev1 milestone Jul 31, 2024
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4299
# Activate the virtual environment
source test-avd-pr-4299/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/gmuloc/avd.git@cut-jsonschemas#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/gmuloc/avd.git#/ansible_collections/arista/avd/,cut-jsonschemas --force
# Optional: Install AVD examples
cd test-avd-pr-4299
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added the type: documentation Improvements or additions to documentation label Jul 31, 2024
@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Jul 31, 2024
@ClausHolbechArista ClausHolbechArista requested a review from a team July 31, 2024 10:32
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the state: conflict PR with conflict label Jul 31, 2024
@github-actions github-actions bot removed the state: conflict PR with conflict label Jul 31, 2024
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

Copy link

sonarcloud bot commented Jul 31, 2024

Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann merged commit ab69358 into aristanetworks:devel Jul 31, 2024
43 checks passed
jrecchia1029 pushed a commit to jrecchia1029/ansible-avd that referenced this pull request Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Cut(eos_cli_config_gen|eos_designs) type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants