Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut(eos_cli_config_gen): Remove the deprecated keys for vlan_interfaces #4305

Merged
merged 8 commits into from
Aug 2, 2024

Conversation

MaheshGSLAB
Copy link
Contributor

Change Summary

Remove the deprecated keys for vlan_interfaces

Related Issue(s)

Fixes #

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Remove the deprecated keys for vlan_interfaces

How to test

Run molecule

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@MaheshGSLAB MaheshGSLAB self-assigned this Aug 1, 2024
Copy link

github-actions bot commented Aug 1, 2024

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4305
# Activate the virtual environment
source test-avd-pr-4305/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/MaheshGSLAB/ansible-avd.git@vlan-interfaces#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/MaheshGSLAB/ansible-avd.git#/ansible_collections/arista/avd/,vlan-interfaces --force
# Optional: Install AVD examples
cd test-avd-pr-4305
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added type: documentation Improvements or additions to documentation role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Aug 1, 2024
@MaheshGSLAB MaheshGSLAB marked this pull request as ready for review August 1, 2024 13:26
@MaheshGSLAB MaheshGSLAB requested review from a team as code owners August 1, 2024 13:26
@MaheshGSLAB MaheshGSLAB requested a review from gmuloc August 2, 2024 05:53
@gmuloc gmuloc added the one approval This PR has one approval and is only missing one more. label Aug 2, 2024
@gmuloc gmuloc requested a review from a team August 2, 2024 06:53
@gmuloc gmuloc added this to the v5.0.0-dev1 milestone Aug 2, 2024
@laxmikantchintakindi
Copy link
Contributor

Copy link

sonarcloud bot commented Aug 2, 2024

@MaheshGSLAB MaheshGSLAB requested a review from gmuloc August 2, 2024 13:10
@gmuloc gmuloc merged commit e4f0773 into aristanetworks:devel Aug 2, 2024
43 checks passed
jrecchia1029 pushed a commit to jrecchia1029/ansible-avd that referenced this pull request Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Cut(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants