Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut(plugins): Remove convert_dicts filter plugin and integrations into schema tooling #4323

Conversation

ClausHolbechArista
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista commented Aug 6, 2024

Change Summary

Remove convert_dicts plugin and integrations into schema tooling

Also cleaning up schema files and metaschema for associated keys.

Keeping primary key for now, since it may be useful later.

Component(s) name

arista.avd.convert_dicts

How to test

Convert_dicts should no longer be in use.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

github-actions bot commented Aug 6, 2024

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4323
# Activate the virtual environment
source test-avd-pr-4323/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ClausHolbechArista/avd.git@cut/plugins/convert-dicts-plugin-and-integrations#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ClausHolbechArista/avd.git#/ansible_collections/arista/avd/,cut/plugins/convert-dicts-plugin-and-integrations --force
# Optional: Install AVD examples
cd test-avd-pr-4323
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added type: documentation Improvements or additions to documentation role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR role: dhcp_provisioner state: Documentation role Updated type: Python filters role: eos_designs issue related to eos_designs role labels Aug 6, 2024
@ClausHolbechArista ClausHolbechArista force-pushed the cut/plugins/convert-dicts-plugin-and-integrations branch from 2fd85f5 to 79a4c55 Compare August 6, 2024 10:54
@github-actions github-actions bot removed state: CI Updated CI scenario have been updated in the PR role: dhcp_provisioner labels Aug 6, 2024
@ClausHolbechArista ClausHolbechArista force-pushed the cut/plugins/convert-dicts-plugin-and-integrations branch from 4d47273 to 999be0f Compare August 6, 2024 11:20
@ClausHolbechArista ClausHolbechArista marked this pull request as ready for review August 6, 2024 11:21
@ClausHolbechArista ClausHolbechArista requested review from a team as code owners August 6, 2024 11:21
@ClausHolbechArista ClausHolbechArista changed the title Cut(plugins): Remove convert_dicts plugin and integrations into schema tooling Cut(plugins): Remove convert_dicts filter plugin and integrations into schema tooling Aug 6, 2024
Copy link
Contributor

@Vibhu-gslab Vibhu-gslab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

sonarcloud bot commented Aug 7, 2024

@ClausHolbechArista ClausHolbechArista merged commit a00bd9e into aristanetworks:devel Aug 8, 2024
45 checks passed
jrecchia1029 pushed a commit to jrecchia1029/ansible-avd that referenced this pull request Aug 14, 2024
@ClausHolbechArista ClausHolbechArista deleted the cut/plugins/convert-dicts-plugin-and-integrations branch August 20, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Cut(plugins) role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_designs issue related to eos_designs role state: Documentation role Updated type: documentation Improvements or additions to documentation type: Python filters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants