-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cut(plugins): Remove convert_dicts filter plugin and integrations into schema tooling #4323
Merged
ClausHolbechArista
merged 7 commits into
aristanetworks:devel
from
ClausHolbechArista:cut/plugins/convert-dicts-plugin-and-integrations
Aug 8, 2024
Merged
Cut(plugins): Remove convert_dicts filter plugin and integrations into schema tooling #4323
ClausHolbechArista
merged 7 commits into
aristanetworks:devel
from
ClausHolbechArista:cut/plugins/convert-dicts-plugin-and-integrations
Aug 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4323
# Activate the virtual environment
source test-avd-pr-4323/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ClausHolbechArista/avd.git@cut/plugins/convert-dicts-plugin-and-integrations#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ClausHolbechArista/avd.git#/ansible_collections/arista/avd/,cut/plugins/convert-dicts-plugin-and-integrations --force
# Optional: Install AVD examples
cd test-avd-pr-4323
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
type: documentation
Improvements or additions to documentation
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
state: CI Updated
CI scenario have been updated in the PR
role: dhcp_provisioner
state: Documentation role Updated
type: Python filters
role: eos_designs
issue related to eos_designs role
labels
Aug 6, 2024
ClausHolbechArista
force-pushed
the
cut/plugins/convert-dicts-plugin-and-integrations
branch
from
August 6, 2024 10:54
2fd85f5
to
79a4c55
Compare
github-actions
bot
removed
state: CI Updated
CI scenario have been updated in the PR
role: dhcp_provisioner
labels
Aug 6, 2024
..._collections/arista/avd/roles/eos_designs/docs/tables/network-services-multicast-settings.md
Outdated
Show resolved
Hide resolved
ClausHolbechArista
force-pushed
the
cut/plugins/convert-dicts-plugin-and-integrations
branch
from
August 6, 2024 11:20
4d47273
to
999be0f
Compare
ClausHolbechArista
changed the title
Cut(plugins): Remove convert_dicts plugin and integrations into schema tooling
Cut(plugins): Remove convert_dicts filter plugin and integrations into schema tooling
Aug 6, 2024
Vibhu-gslab
approved these changes
Aug 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Quality Gate passedIssues Measures |
jrecchia1029
pushed a commit
to jrecchia1029/ansible-avd
that referenced
this pull request
Aug 14, 2024
ClausHolbechArista
deleted the
cut/plugins/convert-dicts-plugin-and-integrations
branch
August 20, 2024 11:29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
rn: Cut(plugins)
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
role: eos_designs
issue related to eos_designs role
state: Documentation role Updated
type: documentation
Improvements or additions to documentation
type: Python filters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Remove convert_dicts plugin and integrations into schema tooling
Also cleaning up schema files and metaschema for associated keys.
Keeping primary key for now, since it may be useful later.
Component(s) name
arista.avd.convert_dicts
How to test
Convert_dicts should no longer be in use.
Checklist
User Checklist
Repository Checklist