Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(eos_cli_config_gen): Remove type column from the documentation of ethernet-interfaces and port-channel-interfaces #4363

Merged

Conversation

Shivani-gslab
Copy link
Contributor

@Shivani-gslab Shivani-gslab commented Aug 14, 2024

Change Summary

Remove type column from documentation in ethernet-interfaces and port-channel-interfaces.
Planning to deprecate this key in upcoming PR.

Updated release notes in favor of PR #4355

Related Issue(s)

Fixes #

Component(s) name

arista.avd.eos_cli_config_gen

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4363
# Activate the virtual environment
source test-avd-pr-4363/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Shivani-gslab/avd.git@remove_type_column#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Shivani-gslab/avd.git#/ansible_collections/arista/avd/,remove_type_column --force
# Optional: Install AVD examples
cd test-avd-pr-4363
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added type: documentation Improvements or additions to documentation type: code quality CI and development toolset state: CI Updated CI scenario have been updated in the PR labels Aug 14, 2024
@Shivani-gslab Shivani-gslab marked this pull request as ready for review August 14, 2024 13:43
@Shivani-gslab Shivani-gslab requested review from a team as code owners August 14, 2024 13:43
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista requested a review from a team August 14, 2024 14:48
@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Aug 14, 2024
ClausHolbechArista and others added 2 commits August 14, 2024 20:02
Co-authored-by: laxmikantchintakindi <159624484+laxmikantchintakindi@users.noreply.github.com>
Copy link

sonarcloud bot commented Aug 14, 2024

@ClausHolbechArista ClausHolbechArista merged commit 6b7e358 into aristanetworks:devel Aug 15, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Refactor(eos_cli_config_gen) state: CI Updated CI scenario have been updated in the PR type: code quality CI and development toolset type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants