-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor(eos_cli_config_gen): Allow duplicate value of address
in router_pim_sparse_mode.rp_addresses
#4366
Merged
ClausHolbechArista
merged 10 commits into
aristanetworks:devel
from
laxmikantchintakindi:todo/router_pim_sparse_mode
Aug 23, 2024
Merged
Refactor(eos_cli_config_gen): Allow duplicate value of address
in router_pim_sparse_mode.rp_addresses
#4366
ClausHolbechArista
merged 10 commits into
aristanetworks:devel
from
laxmikantchintakindi:todo/router_pim_sparse_mode
Aug 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4366
# Activate the virtual environment
source test-avd-pr-4366/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/laxmikantchintakindi/avd.git@todo/router_pim_sparse_mode#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/laxmikantchintakindi/avd.git#/ansible_collections/arista/avd/,todo/router_pim_sparse_mode --force
# Optional: Install AVD examples
cd test-avd-pr-4366
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
state: Documentation role Updated
type: documentation
Improvements or additions to documentation
labels
Aug 16, 2024
laxmikantchintakindi
force-pushed
the
todo/router_pim_sparse_mode
branch
from
August 16, 2024 09:26
cf8d3da
to
745a132
Compare
ClausHolbechArista
requested changes
Aug 16, 2024
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/router_pim_sparse_mode.schema.yml
Show resolved
Hide resolved
github-actions
bot
removed
the
type: documentation
Improvements or additions to documentation
label
Aug 16, 2024
laxmikantchintakindi
force-pushed
the
todo/router_pim_sparse_mode
branch
from
August 19, 2024 07:54
250b6df
to
05a1927
Compare
github-actions
bot
added
the
type: documentation
Improvements or additions to documentation
label
Aug 19, 2024
laxmikantchintakindi
changed the title
Cut(eos_cli_config_gen): Remove primary_key mark in router_pim_sparse_mode.rp_addresses
Cut(eos_cli_config_gen): Allow duplicate value of Aug 19, 2024
address
in router_pim_sparse_mode.rp_addresses
laxmikantchintakindi
changed the title
Cut(eos_cli_config_gen): Allow duplicate value of
Refactor(eos_cli_config_gen): Allow duplicate value of Aug 19, 2024
address
in router_pim_sparse_mode.rp_addresses
address
in router_pim_sparse_mode.rp_addresses
MaheshGSLAB
reviewed
Aug 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add a test having same address two times
github-actions
bot
added
the
state: CI Updated
CI scenario have been updated in the PR
label
Aug 19, 2024
ClausHolbechArista
requested changes
Aug 20, 2024
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/router_pim_sparse_mode.schema.yml
Show resolved
Hide resolved
github-actions
bot
removed
the
type: documentation
Improvements or additions to documentation
label
Aug 20, 2024
ClausHolbechArista
approved these changes
Aug 21, 2024
ClausHolbechArista
added
the
one approval
This PR has one approval and is only missing one more.
label
Aug 21, 2024
MaheshGSLAB
reviewed
Aug 21, 2024
...llections/arista/avd/molecule/eos_cli_config_gen/intended/configs/router-pim-sparse-mode.cfg
Outdated
Show resolved
Hide resolved
…_mode.rp_addresses
for more information, see https://pre-commit.ci
laxmikantchintakindi
force-pushed
the
todo/router_pim_sparse_mode
branch
from
August 22, 2024 10:26
2fb9c36
to
0fffaf4
Compare
github-actions
bot
added
the
type: documentation
Improvements or additions to documentation
label
Aug 22, 2024
github-actions
bot
removed
the
type: documentation
Improvements or additions to documentation
label
Aug 22, 2024
MaheshGSLAB
approved these changes
Aug 22, 2024
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
one approval
This PR has one approval and is only missing one more.
rn: Refactor(eos_cli_config_gen)
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Allow duplicate value of address in router_pim_sparse_mode.rp_addresses.
Related Issue(s)
Fixes #
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
Remove primary_key mark in router_pim_sparse_mode.rp_addresses
How to test
Checklist
User Checklist
Repository Checklist