-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor(eos_cli_config_gen): Rearrange the eos-cli output to match eos order #4381
Merged
ClausHolbechArista
merged 26 commits into
aristanetworks:devel
from
laxmikantchintakindi:refactor/eos_cli_sequence
Sep 23, 2024
Merged
Refactor(eos_cli_config_gen): Rearrange the eos-cli output to match eos order #4381
ClausHolbechArista
merged 26 commits into
aristanetworks:devel
from
laxmikantchintakindi:refactor/eos_cli_sequence
Sep 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4381
# Activate the virtual environment
source test-avd-pr-4381/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/laxmikantchintakindi/avd.git@refactor/eos_cli_sequence#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/laxmikantchintakindi/avd.git#/ansible_collections/arista/avd/,refactor/eos_cli_sequence --force
# Optional: Install AVD examples
cd test-avd-pr-4381
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
the
state: CI Updated
CI scenario have been updated in the PR
label
Aug 20, 2024
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/aaa-server-groups.j2
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/aaa-server-groups.j2
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/molecule/eos_cli_config_gen/inventory/host_vars/aaa.yml
Outdated
Show resolved
Hide resolved
github-actions
bot
removed
the
state: CI Updated
CI scenario have been updated in the PR
label
Aug 20, 2024
laxmikantchintakindi
force-pushed
the
refactor/eos_cli_sequence
branch
from
August 23, 2024 09:08
b25f013
to
5d3b9b8
Compare
github-actions
bot
added
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
state: Documentation role Updated
state: CI Updated
CI scenario have been updated in the PR
labels
Aug 23, 2024
MaheshGSLAB
reviewed
Aug 30, 2024
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/aaa_server_groups.schema.yml
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/event-handlers.cfg
Show resolved
Hide resolved
Vibhu-gslab
reviewed
Sep 2, 2024
ansible_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/event-handlers.cfg
Show resolved
Hide resolved
Vibhu-gslab
reviewed
Sep 2, 2024
ansible_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/event-handlers.cfg
Show resolved
Hide resolved
Vibhu-gslab
reviewed
Sep 2, 2024
ansible_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/flow-tracking.cfg
Show resolved
Hide resolved
laxmikantchintakindi
force-pushed
the
refactor/eos_cli_sequence
branch
from
September 2, 2024 13:08
b35c29d
to
7e1f085
Compare
github-actions
bot
removed
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
state: Documentation role Updated
labels
Sep 2, 2024
MaheshGSLAB
reviewed
Sep 4, 2024
ansible_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/event-handlers.cfg
Show resolved
Hide resolved
ansible_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/flow-tracking.cfg
Show resolved
Hide resolved
ansible_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/groups.cfg
Show resolved
Hide resolved
...ions/arista/avd/molecule/eos_cli_config_gen/intended/configs/ip-client-source-interfaces.cfg
Show resolved
Hide resolved
ansible_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/ip-nat.cfg
Show resolved
Hide resolved
laxmikantchintakindi
force-pushed
the
refactor/eos_cli_sequence
branch
from
September 4, 2024 11:51
a51b0db
to
d7a7a23
Compare
github-actions
bot
added
type: documentation
Improvements or additions to documentation
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
state: Documentation role Updated
role: eos_designs
issue related to eos_designs role
labels
Sep 6, 2024
laxmikantchintakindi
force-pushed
the
refactor/eos_cli_sequence
branch
from
September 6, 2024 06:57
6f9c39e
to
852409b
Compare
github-actions
bot
removed
type: documentation
Improvements or additions to documentation
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
state: Documentation role Updated
role: eos_designs
issue related to eos_designs role
labels
Sep 6, 2024
for more information, see https://pre-commit.ci
…lts, int-groups, ip-client-source-int, ip-nat-part1.
laxmikantchintakindi
force-pushed
the
refactor/eos_cli_sequence
branch
from
September 17, 2024 05:53
edfa891
to
70f6168
Compare
github-actions
bot
removed
type: documentation
Improvements or additions to documentation
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
state: Documentation role Updated
role: eos_designs
issue related to eos_designs role
labels
Sep 17, 2024
MaheshGSLAB
reviewed
Sep 19, 2024
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/event-handlers.j2
Outdated
Show resolved
Hide resolved
ClausHolbechArista
requested changes
Sep 20, 2024
...le_collections/arista/avd/molecule/eos_cli_config_gen/documentation/devices/flow-tracking.md
Show resolved
Hide resolved
...arista/avd/molecule/eos_designs_unit_tests/intended/configs/flow-tracking-tests-l2-leaf1.cfg
Outdated
Show resolved
Hide resolved
laxmikantchintakindi
force-pushed
the
refactor/eos_cli_sequence
branch
from
September 20, 2024 16:52
51fd063
to
bbd3961
Compare
Quality Gate passedIssues Measures |
ClausHolbechArista
approved these changes
Sep 23, 2024
ClausHolbechArista
added
the
one approval
This PR has one approval and is only missing one more.
label
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
one approval
This PR has one approval and is only missing one more.
rn: Refactor(eos_cli_config_gen)
state: CI Updated
CI scenario have been updated in the PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Rearrange the eos-cli output to match eos order.
Added changes to below templates:
Related Issue(s)
Fixes #
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
Rearrange the eos-cli output to match eos order.
How to test
Checklist
User Checklist
Repository Checklist