Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(eos_cli_config_gen): Rearrange the eos-cli output to match eos order #4381

Conversation

laxmikantchintakindi
Copy link
Contributor

@laxmikantchintakindi laxmikantchintakindi commented Aug 20, 2024

Change Summary

Rearrange the eos-cli output to match eos order.
Added changes to below templates:

  • aaa-servers-group
  • as-path
  • cvx
  • daemons
  • dhcp-servers
  • dot1x
  • event-handlers

Related Issue(s)

Fixes #

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Rearrange the eos-cli output to match eos order.

How to test

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4381
# Activate the virtual environment
source test-avd-pr-4381/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/laxmikantchintakindi/avd.git@refactor/eos_cli_sequence#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/laxmikantchintakindi/avd.git#/ansible_collections/arista/avd/,refactor/eos_cli_sequence --force
# Optional: Install AVD examples
cd test-avd-pr-4381
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Aug 20, 2024
@github-actions github-actions bot removed the state: CI Updated CI scenario have been updated in the PR label Aug 20, 2024
@ClausHolbechArista ClausHolbechArista added this to the v5.0.0 milestone Aug 22, 2024
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: Documentation role Updated state: CI Updated CI scenario have been updated in the PR labels Aug 23, 2024
@github-actions github-actions bot added type: documentation Improvements or additions to documentation role: eos_cli_config_gen issue related to eos_cli_config_gen role state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Sep 6, 2024
@github-actions github-actions bot removed type: documentation Improvements or additions to documentation role: eos_cli_config_gen issue related to eos_cli_config_gen role state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Sep 6, 2024
@github-actions github-actions bot removed type: documentation Improvements or additions to documentation role: eos_cli_config_gen issue related to eos_cli_config_gen role state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Sep 17, 2024
Laxmikant Chintakindi added 2 commits September 20, 2024 21:51
Copy link

sonarcloud bot commented Sep 23, 2024

@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Sep 23, 2024
@ClausHolbechArista ClausHolbechArista merged commit 5815dca into aristanetworks:devel Sep 23, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Refactor(eos_cli_config_gen) state: CI Updated CI scenario have been updated in the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants