Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Add support for snmp-server ipmib ifspeed shape-rate #4382

Merged
merged 8 commits into from
Aug 22, 2024

Conversation

gusmb
Copy link
Contributor

@gusmb gusmb commented Aug 21, 2024

Change Summary

Add support for SNMP server shape-rate

Related Issue(s)

Fixes #4377

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Adds following knob to snmp-server:

snmp_server:
  ifmib_ifspeed_shape_rate: <bool>

How to test

See molecule test

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gusmb gusmb requested review from a team as code owners August 21, 2024 08:31
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4382
# Activate the virtual environment
source test-avd-pr-4382/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/gusmb/ansible-avd.git@issue4377#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/gusmb/ansible-avd.git#/ansible_collections/arista/avd/,issue4377 --force
# Optional: Install AVD examples
cd test-avd-pr-4382
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Aug 21, 2024
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far. Only needs a run of molecule to get the test artifacts updated.

cd ansible_collections/arista/avd
molecule converge -s eos_cli_config_gen -- --limit snmp

@github-actions github-actions bot added the state: conflict PR with conflict label Aug 21, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the state: conflict PR with conflict label Aug 21, 2024
@ClausHolbechArista
Copy link
Contributor

I have committed a few changes to your PR to unblock the CI.

@gusmb
Copy link
Contributor Author

gusmb commented Aug 21, 2024

cd ansible_collections/arista/avd
molecule converge -s eos_cli_config_gen -- --limit snmp

Is it possible for you to run it? I am using the dev container at the moment and getting a few issues with pre-commit, dependencies are not installed etc. Probably need to rebuild my environment

@ClausHolbechArista ClausHolbechArista requested a review from a team August 21, 2024 09:03
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Verified command order on EOS.

@ClausHolbechArista ClausHolbechArista requested a review from a team August 21, 2024 09:14
@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Aug 21, 2024
@ClausHolbechArista ClausHolbechArista changed the title Feat(eos_cli_config_gen): Add support for additional SNMP CLI Feat(eos_cli_config_gen): Add support for snmp-server ipmib ifspeed shape-rate Aug 21, 2024
Copy link

sonarcloud bot commented Aug 21, 2024

@ClausHolbechArista ClausHolbechArista merged commit 0beaa83 into aristanetworks:devel Aug 22, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat (eos_cli_config_gen): Add support for SNMP server shape-rate
3 participants