-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_cli_config_gen): Add support for snmp-server ipmib ifspeed shape-rate #4382
Conversation
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4382
# Activate the virtual environment
source test-avd-pr-4382/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/gusmb/ansible-avd.git@issue4377#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/gusmb/ansible-avd.git#/ansible_collections/arista/avd/,issue4377 --force
# Optional: Install AVD examples
cd test-avd-pr-4382
ansible-playbook arista.avd.install_examples |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM so far. Only needs a run of molecule to get the test artifacts updated.
cd ansible_collections/arista/avd
molecule converge -s eos_cli_config_gen -- --limit snmp
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
I have committed a few changes to your PR to unblock the CI. |
Is it possible for you to run it? I am using the dev container at the moment and getting a few issues with pre-commit, dependencies are not installed etc. Probably need to rebuild my environment |
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/snmp_server.schema.yml
Outdated
Show resolved
Hide resolved
…nmp_server.schema.yml
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Verified command order on EOS.
Quality Gate passedIssues Measures |
Change Summary
Add support for SNMP server shape-rate
Related Issue(s)
Fixes #4377
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
Adds following knob to
snmp-server
:How to test
See molecule test
Checklist
User Checklist
Repository Checklist