Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(eos_designs)!: Add missing BGP peer description for MLAG peerings in VRFs #4394

Conversation

ClausHolbechArista
Copy link
Contributor

Change Summary

Add missing BGP peer description for MLAG peerings in VRFs

Related Issue(s)

Fixes #

Component(s) name

arista.avd.eos_designs

Proposed changes

Add missing BGP peer description for all MLAG peerings in VRFs.

How to test

Existing molecule artifacts got updated.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4394
# Activate the virtual environment
source test-avd-pr-4394/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ClausHolbechArista/avd.git@fix/eos_designs/add-description-to-bgp-mlag-peer-in-vrf#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ClausHolbechArista/avd.git#/ansible_collections/arista/avd/,fix/eos_designs/add-description-to-bgp-mlag-peer-in-vrf --force
# Optional: Install AVD examples
cd test-avd-pr-4394
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Aug 27, 2024
Copy link

sonarcloud bot commented Aug 27, 2024

Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmuloc gmuloc requested a review from a team August 27, 2024 08:14
@gmuloc gmuloc added the one approval This PR has one approval and is only missing one more. label Aug 27, 2024
@ClausHolbechArista ClausHolbechArista merged commit cf99195 into aristanetworks:devel Aug 27, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Fix(eos_designs)! state: CI Updated CI scenario have been updated in the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants