Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(eos_cli_config_gen): Deprecate community_lists data model #4396

Merged
merged 7 commits into from
Aug 28, 2024

Conversation

laxmikantchintakindi
Copy link
Contributor

@laxmikantchintakindi laxmikantchintakindi commented Aug 27, 2024

Change Summary

Deprecate community_lists data model.

Related Issue(s)

Fixes #

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Deprecate community_lists data model.

How to test

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4396
# Activate the virtual environment
source test-avd-pr-4396/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/laxmikantchintakindi/avd.git@cut/community_list#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/laxmikantchintakindi/avd.git#/ansible_collections/arista/avd/,cut/community_list --force
# Optional: Install AVD examples
cd test-avd-pr-4396
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added type: documentation Improvements or additions to documentation role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Aug 27, 2024
@laxmikantchintakindi laxmikantchintakindi marked this pull request as ready for review August 27, 2024 13:36
@gmuloc gmuloc added the one approval This PR has one approval and is only missing one more. label Aug 27, 2024
@gmuloc gmuloc requested review from a team and gmuloc August 27, 2024 13:46
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cancelling my approval - we need to deprecate first to follow semver - so you can
1/ rollback your change
2/ deprecate the key (with removed: false)
3/ move the test to the deprecated scenario

@gmuloc gmuloc removed the one approval This PR has one approval and is only missing one more. label Aug 27, 2024
@github-actions github-actions bot removed the type: documentation Improvements or additions to documentation label Aug 27, 2024
@laxmikantchintakindi laxmikantchintakindi changed the title Cut(eos_cli_config_gen): Deprecate community_lists data model Refactor(eos_cli_config_gen): Deprecate community_lists data model Aug 27, 2024
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmuloc gmuloc added the one approval This PR has one approval and is only missing one more. label Aug 28, 2024
Copy link

sonarcloud bot commented Aug 28, 2024

@gmuloc gmuloc merged commit 92118f7 into aristanetworks:devel Aug 28, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Refactor(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants