-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor(eos_cli_config_gen): Deprecate community_lists
data model
#4396
Refactor(eos_cli_config_gen): Deprecate community_lists
data model
#4396
Conversation
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4396
# Activate the virtual environment
source test-avd-pr-4396/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/laxmikantchintakindi/avd.git@cut/community_list#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/laxmikantchintakindi/avd.git#/ansible_collections/arista/avd/,cut/community_list --force
# Optional: Install AVD examples
cd test-avd-pr-4396
ansible-playbook arista.avd.install_examples |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cancelling my approval - we need to deprecate first to follow semver - so you can
1/ rollback your change
2/ deprecate the key (with removed: false)
3/ move the test to the deprecated scenario
community_lists
data modelcommunity_lists
data model
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/community_lists.schema.yml
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/community_lists.schema.yml
Outdated
Show resolved
Hide resolved
0f5ed59
to
05186d4
Compare
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/community-lists.j2
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos-intended-config.j2
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/filters.j2
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Quality Gate passedIssues Measures |
Change Summary
Deprecate
community_lists
data model.Related Issue(s)
Fixes #
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
Deprecate
community_lists
data model.How to test
Checklist
User Checklist
Repository Checklist