Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(eos_cli_config_gen)!: Make router_traffic_engineering.enabled required #4403

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Aug 28, 2024

Change Summary

As described in the issue - right now AVD 4.0.0 renders config with an empty dict which we don't want.

Related Issue(s)

Fixes #3281

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Make enabled required in schema and fix the template logic

How to test

molecule

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gmuloc gmuloc requested review from a team as code owners August 28, 2024 09:18
@gmuloc gmuloc added this to the v5.0.0 milestone Aug 28, 2024
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4403
# Activate the virtual environment
source test-avd-pr-4403/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/gmuloc/avd.git@issue/3281#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/gmuloc/avd.git#/ansible_collections/arista/avd/,issue/3281 --force
# Optional: Install AVD examples
cd test-avd-pr-4403
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added type: documentation Improvements or additions to documentation role: eos_cli_config_gen issue related to eos_cli_config_gen role state: Documentation role Updated labels Aug 28, 2024
Copy link

sonarcloud bot commented Aug 28, 2024

Copy link
Contributor

@Vibhu-gslab Vibhu-gslab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ClausHolbechArista ClausHolbechArista merged commit 7cd121d into aristanetworks:devel Aug 28, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Refactor(eos_cli_config_gen)! role: eos_cli_config_gen issue related to eos_cli_config_gen role state: Documentation role Updated type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor(eos_cli_config_gen)!: Make enabled flag required for router_traffic_engineering
3 participants