-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor(cv_deploy): Optimize push of configlets with version aware API calls #4419
Merged
ClausHolbechArista
merged 16 commits into
aristanetworks:devel
from
ClausHolbechArista:refactor/cv_deploy/optimize-configlet-messages
Sep 12, 2024
Merged
Refactor(cv_deploy): Optimize push of configlets with version aware API calls #4419
ClausHolbechArista
merged 16 commits into
aristanetworks:devel
from
ClausHolbechArista:refactor/cv_deploy/optimize-configlet-messages
Sep 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4419
# Activate the virtual environment
source test-avd-pr-4419/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ClausHolbechArista/avd.git@refactor/cv_deploy/optimize-configlet-messages#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ClausHolbechArista/avd.git#/ansible_collections/arista/avd/,refactor/cv_deploy/optimize-configlet-messages --force
# Optional: Install AVD examples
cd test-avd-pr-4419
ansible-playbook arista.avd.install_examples |
ClausHolbechArista
changed the title
Refactor(cv deploy): Optimize push of configlets with version aware API calls
Refactor(cv_deploy): Optimize push of configlets with version aware API calls
Sep 2, 2024
gmuloc
reviewed
Sep 5, 2024
gmuloc
approved these changes
Sep 6, 2024
ClausHolbechArista
added
the
one approval
This PR has one approval and is only missing one more.
label
Sep 6, 2024
alexeygorbunov
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and worked on 2024.1.2 and CVaaS:
wrapper_cv_version: Called 'set_configlets_from_files' with version '2024.1.2'
set_configlets_from_files: Deploying 10 configlets in batches of 20.
set_configlets_from_files: Batch 1
Adding (b':path', b'/arista.configlet.v1.ConfigletConfigService/Set')
wrapper_cv_version: Called 'set_configlets_from_files' with version 'CVaaS'
wrapper_grpc_msg_size_handler: Called 'set_configlets_from_files' with '10' items
Adding (b':path', b'/arista.configlet.v1.ConfigletConfigService/SetSome')
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
one approval
This PR has one approval and is only missing one more.
rn: Refactor(cv_deploy)
state: Documentation role Updated
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Optimize push of configlets with version aware API calls
Component(s) name
arista.avd.cv_deploy
Proposed changes
SetSome
for newer versions for pushing configlets and containersSet
for older versions.How to test
Tested manually:
SetSome
method with overflow of max message sizes.Set
in batches of 20 parallel operations. (fails after ~1000 because of CV issue)SetSome
method packed to a single message.SetSome
method packed to a single message.SetSome
method packed to a single message.Checklist
User Checklist
Repository Checklist