Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #275 add device document for management API HTTP #443

Merged
merged 3 commits into from
Dec 8, 2020
Merged

issue #275 add device document for management API HTTP #443

merged 3 commits into from
Dec 8, 2020

Conversation

ksator
Copy link
Contributor

@ksator ksator commented Dec 8, 2020

Change Summary

updated the role eos_cli_config_gen to generate device configuration for management API HTTP

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Documentation content changes
  • Other (please describe):

Related Issue(s)

Fix #275

Component(s) name

role eos_cli_config_gen

Proposed changes

updated the role eos_cli_config_gen to generate device configuration for management API HTTP

  • created the template that generate this configuration
  • updated the master template to include the new template and to update the Table of Contents

How to test

Once you define devices vars to generate device configuration, run the role eos_cli_config_gen.
In addition to the device config it will generate the device documentation

Example

management_api_http:
  enable_http: true 
  enable_https: false 
  enable_vrfs:
    whatever:
      access_group: IPv4_ACL
      ipv6_access_group: IPv6_ACL
    another_vrf:

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed (pre-commit, make linting and make sanity-lint).
  • I have updated molecule CI testing accordingly

@ksator ksator self-assigned this Dec 8, 2020
@github-actions github-actions bot added the role: eos_cli_config_gen issue related to eos_cli_config_gen role label Dec 8, 2020
@ksator ksator added type: documentation Improvements or additions to documentation and removed role: eos_cli_config_gen issue related to eos_cli_config_gen role labels Dec 8, 2020
@ksator ksator added the role: eos_cli_config_gen issue related to eos_cli_config_gen role label Dec 8, 2020
@aphillipps aphillipps self-requested a review December 8, 2020 19:32
Copy link
Contributor

@aphillipps aphillipps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ksator ksator merged commit 56b7eae into aristanetworks:devel Dec 8, 2020
@titom73 titom73 added this to the v1.1.2 milestone Dec 10, 2020
@ksator ksator deleted the issue/275-1 branch December 16, 2020 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Management API Device Documentation Template to be completed
3 participants