Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(eos_designs)!: Change default mlag interface descriptions #4464

Conversation

ClausHolbechArista
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista commented Sep 13, 2024

Change Summary

Change default mlag interface descriptions

Component(s) name

arista.avd.eos_designs

Proposed changes

  • Adding new default descriptions for MLAG interfaces
  • Add templating support for both member interfaces and port-channel interface descriptions
  • Add keys with default templates:
    • mlag_member_description
    • mlag_port_channel_description
  • Updated porting guide

How to test

  • Update molecule scenarios and examples
  • Verified that custom description logic still works in unit tests for templates and python module
  • Verified that custom description logic still works in evpn_underlay_ebgp_overlay_ebgp for python module

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4464
# Activate the virtual environment
source test-avd-pr-4464/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ClausHolbechArista/avd.git@refactor/eos_designs/mlag-descriptions#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ClausHolbechArista/avd.git#/ansible_collections/arista/avd/,refactor/eos_designs/mlag-descriptions --force
# Optional: Install AVD examples
cd test-avd-pr-4464
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added type: documentation Improvements or additions to documentation state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role state: conflict PR with conflict labels Sep 13, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@ClausHolbechArista ClausHolbechArista force-pushed the refactor/eos_designs/mlag-descriptions branch from 7ea040b to 7df6bf1 Compare September 17, 2024 07:22
@github-actions github-actions bot removed the state: conflict PR with conflict label Sep 17, 2024
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@ClausHolbechArista ClausHolbechArista force-pushed the refactor/eos_designs/mlag-descriptions branch from 7df6bf1 to 0830a73 Compare September 24, 2024 09:22
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the state: conflict PR with conflict label Sep 24, 2024
@ClausHolbechArista ClausHolbechArista marked this pull request as ready for review September 24, 2024 09:22
@ClausHolbechArista ClausHolbechArista marked this pull request as draft September 24, 2024 09:24
@ClausHolbechArista ClausHolbechArista force-pushed the refactor/eos_designs/mlag-descriptions branch from 0830a73 to fbaa2dc Compare September 24, 2024 09:48
@ClausHolbechArista ClausHolbechArista force-pushed the refactor/eos_designs/mlag-descriptions branch from fbaa2dc to cc48d9a Compare September 24, 2024 12:15
@ClausHolbechArista ClausHolbechArista marked this pull request as ready for review September 24, 2024 12:39
@gmuloc gmuloc added the one approval This PR has one approval and is only missing one more. label Sep 24, 2024
Copy link

sonarcloud bot commented Sep 24, 2024

@ClausHolbechArista ClausHolbechArista requested a review from a team September 24, 2024 13:57
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann merged commit a98e6bc into aristanetworks:devel Sep 24, 2024
40 checks passed
@ClausHolbechArista ClausHolbechArista deleted the refactor/eos_designs/mlag-descriptions branch September 27, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Refactor(eos_designs)! role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants