Fix(eos_cli_config_gen): Remove primary key of system.control_plane.ipv4/6_access_group and make vrf key unique #4465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4465
# Activate the virtual environment
source test-avd-pr-4465/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Vibhu-gslab/avd.git@control_plane#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Vibhu-gslab/avd.git#/ansible_collections/arista/avd/,control_plane --force
# Optional: Install AVD examples
cd test-avd-pr-4465
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
role: eos_cli_config_gen
laxmikantchintakindi
approved these changes
Sep 13, 2024
Vibhu-gslab
force-pushed
the
control_plane
branch
from
c654f01
to
4b0f0bb
Compare
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/system.schema.yml
Show resolved
Hide resolved
ClausHolbechArista
approved these changes
Sep 16, 2024
…ane.ipv4/6_access_group and make vrf key unique
Vibhu-gslab
force-pushed
the
control_plane
branch
from
51197fa
to
c6ad676
Compare
|
ClausHolbechArista
changed the title
github-actions
bot
added
rn: Refactor(eos_cli_config_gen)
rn: Fix(eos_cli_config_gen)
and removed
rn: Refactor(eos_cli_config_gen)
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Remove primary key of system.control_plane.ipv4/6_access_group and make vrf key unique
Related Issue(s)
Fixes #4446
Component(s) name
arista.avd.eos_cli_config_genProposed changes
Removed primary_key: acl_name and added
vrfkey in the list of unique_keys.How to test
CI will test
Checklist
Repository Checklist