Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc(eos_cli_config_gen): Add missing tables to input-variables #4469

Merged

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Sep 13, 2024

Change Summary

Missing tables

  • monitor-session-default-encapsulation-gre.md
  • monitor-telemetry-influx.md
  • monitor-telemetry-postcard-policy.md

Related Issue(s)

Reported by field

Component(s) name

arista.avd.eos_cli_config
documentation

Proposed changes

Adding tables

How to test

check doc

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gmuloc gmuloc requested review from a team as code owners September 13, 2024 13:57
@gmuloc gmuloc added this to the v5.0.0 milestone Sep 13, 2024
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4469
# Activate the virtual environment
source test-avd-pr-4469/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/gmuloc/avd.git@monitor-postcard-telemetry-doc#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/gmuloc/avd.git#/ansible_collections/arista/avd/,monitor-postcard-telemetry-doc --force
# Optional: Install AVD examples
cd test-avd-pr-4469
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: Documentation role Updated labels Sep 13, 2024
Copy link

sonarcloud bot commented Sep 13, 2024

Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@alexeygorbunov alexeygorbunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann merged commit f406ff9 into aristanetworks:devel Sep 13, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants