Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(eos_designs): Remove "preview" from flow_tracking_settings #4472

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Sep 16, 2024

Change Summary

cf title

Component(s) name

arista.avd.eos_designs

Proposed changes

Making flow_tracking_settings not preview anymore

How to test

Check that PREVIEW is gone in schema and doc

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gmuloc gmuloc requested review from a team as code owners September 16, 2024 09:59
@gmuloc gmuloc modified the milestones: v6.0.0, v5.0.0 Sep 16, 2024
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4472
# Activate the virtual environment
source test-avd-pr-4472/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/gmuloc/avd.git@remove-preview-sflow#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/gmuloc/avd.git#/ansible_collections/arista/avd/,remove-preview-sflow --force
# Optional: Install AVD examples
cd test-avd-pr-4472
ansible-playbook arista.avd.install_examples

Copy link

sonarcloud bot commented Sep 16, 2024

@ClausHolbechArista ClausHolbechArista changed the title Refactor(eos_designs): Remove PREVIEW from flow_tracking_settings Refactor(eos_designs): Remove "preview" from flow_tracking_settings Sep 16, 2024
@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Sep 16, 2024
@ClausHolbechArista ClausHolbechArista requested a review from a team September 16, 2024 11:06
Copy link
Contributor

@emilarista emilarista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM!

@gmuloc gmuloc merged commit fb085fb into aristanetworks:devel Sep 16, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EPIC - AVD AutoVPN/WAN one approval This PR has one approval and is only missing one more. rn: Refactor(eos_designs) role: eos_designs issue related to eos_designs role state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants