Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Add support for port-channel local interfaces for router-path-selection #4475

Merged
merged 4 commits into from
Sep 17, 2024

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Sep 16, 2024

Change Summary

Cf title

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Add the possibility to configure Port-Channel in the regex.

How to test

New tests in molecule

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gmuloc gmuloc requested review from a team as code owners September 16, 2024 14:04
@gmuloc gmuloc added this to the v5.0.0 milestone Sep 16, 2024
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4475
# Activate the virtual environment
source test-avd-pr-4475/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/gmuloc/avd.git@cli-config-gen#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/gmuloc/avd.git#/ansible_collections/arista/avd/,cli-config-gen --force
# Optional: Install AVD examples
cd test-avd-pr-4475
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Sep 16, 2024
Copy link

sonarcloud bot commented Sep 17, 2024

@ClausHolbechArista ClausHolbechArista merged commit 6051cd3 into aristanetworks:devel Sep 17, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants