Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(eos_cli_config_gen): Change the 'protocol' key to 'encapsulation' in interfaces-encapsulation model #4509

Merged
merged 3 commits into from
Sep 24, 2024

Conversation

Shivani-gslab
Copy link
Contributor

@Shivani-gslab Shivani-gslab commented Sep 24, 2024

Change Summary

Change the 'protocol' key to 'encapsulation' in interfaces-encapsulation model

Related Issue(s)

Fixes #

Component(s) name

arista.avd.<role-name>

Proposed changes

How to test

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4509
# Activate the virtual environment
source test-avd-pr-4509/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Shivani-gslab/avd.git@encapsulation_fix#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Shivani-gslab/avd.git#/ansible_collections/arista/avd/,encapsulation_fix --force
# Optional: Install AVD examples
cd test-avd-pr-4509
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Sep 24, 2024
@Shivani-gslab Shivani-gslab changed the title Refactore(eos_cli_config_gen): Change the 'protocol' key to 'encapsulation' in interfaces-encapsulation model Refactor(eos_cli_config_gen): Change the 'protocol' key to 'encapsulation' in interfaces-encapsulation model Sep 24, 2024
@gmuloc gmuloc added this to the v5.0.0 milestone Sep 24, 2024
@Shivani-gslab Shivani-gslab marked this pull request as ready for review September 24, 2024 09:49
@Shivani-gslab Shivani-gslab requested review from a team as code owners September 24, 2024 09:49
Shivani-gslab added a commit to Shivani-gslab/avd that referenced this pull request Sep 24, 2024
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update the porting guide: https://avd.arista.com/devel/docs/porting-guides/5.x.x.html#encapsulation-configuration-and-documentation

there are mention of protocols

@github-actions github-actions bot added the type: documentation Improvements or additions to documentation label Sep 24, 2024
Copy link

@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Sep 24, 2024
@gmuloc gmuloc merged commit 4e88b05 into aristanetworks:devel Sep 24, 2024
43 checks passed
@Shivani-gslab Shivani-gslab deleted the encapsulation_fix branch February 11, 2025 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Refactor(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants