-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor(eos_cli_config_gen): Change the 'protocol' key to 'encapsulation' in interfaces-encapsulation model #4509
Conversation
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4509
# Activate the virtual environment
source test-avd-pr-4509/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Shivani-gslab/avd.git@encapsulation_fix#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Shivani-gslab/avd.git#/ansible_collections/arista/avd/,encapsulation_fix --force
# Optional: Install AVD examples
cd test-avd-pr-4509
ansible-playbook arista.avd.install_examples |
3d9423d
to
87c451c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also update the porting guide: https://avd.arista.com/devel/docs/porting-guides/5.x.x.html#encapsulation-configuration-and-documentation
there are mention of protocols
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/port_channel_interfaces.schema.yml
Outdated
Show resolved
Hide resolved
…ation' in interfaces-encapsulation model
6174a6a
to
7f7f541
Compare
|
Change Summary
Change the 'protocol' key to 'encapsulation' in interfaces-encapsulation model
Related Issue(s)
Fixes #
Component(s) name
arista.avd.<role-name>
Proposed changes
How to test
Checklist
User Checklist
Repository Checklist