Fix(eos_designs): Add redistribute connected under BGP for VRF default if no underlay #4522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4522
# Activate the virtual environment
source test-avd-pr-4522/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ClausHolbechArista/avd.git@fix/eos_designs/redistribute-connected-in-bgp-vrf-default-from-network-services#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ClausHolbechArista/avd.git#/ansible_collections/arista/avd/,fix/eos_designs/redistribute-connected-in-bgp-vrf-default-from-network-services --force
# Optional: Install AVD examples
cd test-avd-pr-4522
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
state: CI Updated
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
…gp-vrf-default-from-network-services
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
carlbuchmann
added
the
cherry-pick-for-4.10.x
…gp-vrf-default-from-network-services
|
@carlbuchmann I don't think this will apply to 4.x since we did not support the corner case we hit here. It is part of the new BGP behavior when not using overlays. |
…gp-vrf-default-from-network-services
gmuloc
requested changes
Sep 30, 2024
python-avd/pyavd/_eos_designs/structured_config/network_services/router_bgp.py
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/network_services/router_bgp.py
Outdated
Show resolved
Hide resolved
gmuloc
added
the
one approval
…es/router_bgp.py Co-authored-by: Guillaume Mulocher <gmulocher@arista.com>
|
gmuloc
approved these changes
Sep 30, 2024
ClausHolbechArista
removed
the
cherry-pick-for-4.10.x
ClausHolbechArista
deleted the
fix/eos_designs/redistribute-connected-in-bgp-vrf-default-from-network-services
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Add redistribute connected under BGP for VRF default if no underlay
Component(s) name
arista.avd.eos_designsProposed changes
In the corner case where we build BGP config for VRF default as part of network services (but not for underlay/overlay), we were missing "redistribute connected".
There will be a PR later to provide control for redistribute connected.
How to test
Existing molecule exposed the issue and show the fix.
Checklist
User Checklist
Repository Checklist