-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor(eos_designs)!: Change L2 uplink description #4532
Refactor(eos_designs)!: Change L2 uplink description #4532
Conversation
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4532
# Activate the virtual environment
source test-avd-pr-4532/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ClausHolbechArista/avd.git@refactor/eos_designs/l2-uplink-descriptions#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ClausHolbechArista/avd.git#/ansible_collections/arista/avd/,refactor/eos_designs/l2-uplink-descriptions --force
# Optional: Install AVD examples
cd test-avd-pr-4532
ansible-playbook arista.avd.install_examples |
ff19a1b
to
a703d70
Compare
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
...d/pyavd/_eos_designs/schema/schema_fragments/underlay_l2_port_channel_description.schema.yml
Outdated
Show resolved
Hide resolved
…_l2_port_channel_description.schema.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after CI complete (pre-commit needs to re run as I just fixed a typo in the schema)
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - tested reverting back to 4.x syntax in local inventory.
Change Summary
Change L2 uplink description
Change Summary
Component(s) name
arista.avd.eos_designs
Proposed changes
underlay_l2_ethernet_description
underlay_l2_port_channel_description
How to test
Checklist
User Checklist
Repository Checklist