Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(eos_cli_config_gen): Rearrange the order of management api http in eos-intended-config based on eos cli #4535

Conversation

Vibhu-gslab
Copy link
Contributor

Change Summary

Fixing the order of management api http upon checking different EOS versions.

Related Issue(s)

Fixes #4466

Component(s) name

arista.avd.eos_cli_config_gen

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@Vibhu-gslab Vibhu-gslab self-assigned this Oct 1, 2024
Copy link

github-actions bot commented Oct 1, 2024

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4535
# Activate the virtual environment
source test-avd-pr-4535/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Vibhu-gslab/avd.git@management_api_http_order#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Vibhu-gslab/avd.git#/ansible_collections/arista/avd/,management_api_http_order --force
# Optional: Install AVD examples
cd test-avd-pr-4535
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Oct 1, 2024
Copy link

sonarcloud bot commented Oct 1, 2024

@Vibhu-gslab Vibhu-gslab marked this pull request as ready for review October 1, 2024 11:50
@Vibhu-gslab Vibhu-gslab requested review from a team as code owners October 1, 2024 11:50
@MaheshGSLAB MaheshGSLAB added this to the v5.0.0 milestone Oct 1, 2024
@ClausHolbechArista ClausHolbechArista merged commit 28051ac into aristanetworks:devel Oct 1, 2024
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Refactor(eos_cli_config_gen) state: CI Updated CI scenario have been updated in the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the order of management api http
4 participants