Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ISIS interfaces documentation #454

Merged
merged 6 commits into from
Dec 11, 2020
Merged

Add ISIS interfaces documentation #454

merged 6 commits into from
Dec 11, 2020

Conversation

ksator
Copy link
Contributor

@ksator ksator commented Dec 10, 2020

Change Summary

add interfaces (ethernet and vlan and loopback) to isis device documentation

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Documentation content changes
  • Other (please describe):

Component(s) name

role eos_cli_config_gen

Proposed changes

created a template to generate device documentation for isis interfaces (ethernet/loopback/vlan)

How to test

router_isis:
  instance: EVPN_UNDERLAY
  net: 49.0001.0001.0001.0001.00
  router_id: 192.168.255.3
  no_passive_interfaces:
  - Ethernet1
  - Ethernet2
  - Vlan4093
  - Loopback1
  is_type: level-2
  address_family:
  - ipv4 unicast
  isis_af_defaults:
  - maximum-paths 2

ethernet_interfaces:
  Ethernet1:
    ip_address: 172.31.255.1/31
    isis_enable: EVPN_UNDERLAY
    isis_metric: 50
    isis_network_point_to_point: true
  Ethernet2:
    ip_address: 172.31.255.3/31
    isis_enable: EVPN_UNDERLAY
    isis_metric: 50
    isis_network_point_to_point: true
    
vlan_interfaces:
  Vlan4093:
    description: MLAG_PEER_L3_PEERING
    ip_address: 10.255.251.0/31
    isis_enable: EVPN_UNDERLAY
    isis_metric: 50
    isis_network_point_to_point: true
  Vlan4094:
    description: MLAG_PEER
    ip_address: 10.255.252.0/31
    no_autostate: true
    mtu: 1500



loopback_interfaces:
  Loopback0:
    description: EVPN_Overlay_Peering
    ip_address: 192.168.255.3/32
    isis_enable: EVPN_UNDERLAY
    isis_passive: true
  Loopback1:
    description: VTEP_VXLAN_Tunnel_Source
    ip_address: 192.168.254.3/32
    isis_enable: EVPN_UNDERLAY
    isis_passive: true

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed (pre-commit, make linting and make sanity-lint).
  • I have updated molecule CI testing accordingly

@ksator ksator added type: documentation Improvements or additions to documentation role: eos_cli_config_gen issue related to eos_cli_config_gen role labels Dec 10, 2020
@ksator ksator self-assigned this Dec 10, 2020
Copy link
Contributor

@titom73 titom73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix table structure and add port-channel interfaces support

@titom73 titom73 self-requested a review December 10, 2020 13:52
Copy link
Contributor

@titom73 titom73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@titom73 titom73 changed the title add isis interfaces documentation Add ISIS interfaces documentation Dec 11, 2020
@titom73 titom73 added this to the v1.1.2 milestone Dec 11, 2020
@titom73 titom73 linked an issue Dec 11, 2020 that may be closed by this pull request
Copy link
Contributor

@aphillipps aphillipps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann merged commit 7253e2e into aristanetworks:devel Dec 11, 2020
@ksator ksator deleted the issue/452 branch December 16, 2020 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update isis doc
4 participants